Keep eth1 for multi-asic disaggregated chassis platforms#24298
Merged
kperumalbfn merged 2 commits intosonic-net:masterfrom Oct 28, 2025
Merged
Keep eth1 for multi-asic disaggregated chassis platforms#24298kperumalbfn merged 2 commits intosonic-net:masterfrom
kperumalbfn merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR extends the fix from #24198 to preserve the eth1 midplane interface for multi-ASIC disaggregated chassis platforms. The original fix only addressed single-ASIC platforms.
Key changes:
- Added debug logging to indicate when midplane interface reservation occurs
- Moved variable initialization and conditional logic to handle multi-ASIC scenarios correctly
- Ensures consistency between single-ASIC and multi-ASIC code paths
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| last_line=$$(tail -n 1 device/x86_64-kvm_x86_64-r0/$$(basename $$d)/$$(basename $$subdir)/port_config.ini); \ | ||
| num_columns=$$(echo $$last_line | awk '{print NF}'); \ | ||
| while IFS= read -r line; do \ | ||
| while IFS= read -r line || [ -n "$$line" ]; do \ |
Contributor
Author
There was a problem hiding this comment.
No, line 116 is for allocating an intf for cpu port
Contributor
Author
There was a problem hiding this comment.
T2 KVM PR checker will fail if this change impacted traditional chassis. For now, we don't have dedicated sanity test for virtual DT2.
deepak-singhal0408
approved these changes
Oct 23, 2025
kperumalbfn
approved these changes
Oct 28, 2025
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
…4298) Keep eth1 for multi-asic disaggregated chassis platforms Signed-off-by: Feng Pan <[email protected]>
xwjiang-ms
pushed a commit
to xwjiang-ms/sonic-buildimage
that referenced
this pull request
Dec 22, 2025
…4298) Keep eth1 for multi-asic disaggregated chassis platforms Signed-off-by: xiaweijiang <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
My original PR #24198 only fixed the eth1 problem for single-asic disaggregated chassis platform but it didn't resolve the problem for multi-asic platforms.
Work item tracking
How I did it
Applied the same logic change in #24198 for multi-asic scenario.
How to verify it
Build a new sonic-device-data deb package and install it on a device. Then, check the HwSKU directory.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)