Skip to content

[Nexthop] NH-5010 Platform Support#24169

Merged
rlhui merged 13 commits intosonic-net:masterfrom
nexthop-ai:nh-5010-platform
Oct 31, 2025
Merged

[Nexthop] NH-5010 Platform Support#24169
rlhui merged 13 commits intosonic-net:masterfrom
nexthop-ai:nh-5010-platform

Conversation

@roy-nexthop
Copy link
Contributor

@roy-nexthop roy-nexthop commented Sep 30, 2025

Why I did it

Adds support for the Nexthop NH-5010 platform

Work item tracking
  • Microsoft ADO (number only):

How I did it

Add platform changes to:

  • device/nexthop
  • platform/broadcom/sonic-platform-modules-nexthop

How to verify it

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@roy-nexthop roy-nexthop marked this pull request as ready for review October 7, 2025 20:50
@roy-nexthop roy-nexthop requested a review from lguohan as a code owner October 7, 2025 20:50
@eswaran-nexthop
Copy link

@arlakshm to review

@@ -0,0 +1,3 @@
[Unit]
Wants=pmon.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the main reasons is to ensure thermal control starts before swss begins enabling interfaces.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change means the swss will not start till pmon is started? @judyjoseph for viz...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arlakshm correct

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another reason we added this is because if xcvrd programs the xcvrs after the port is enabled the link could flap. Ideally there is a generic solution where orchagent keeps the port disabled until xcvrd has programmed the xcvr. Until something like that is implemented we're adding this as a temporary improvement for Nexthop platforms.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -0,0 +1,3 @@
[Unit]
Wants=pmon.service
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change means the swss will not start till pmon is started? @judyjoseph for viz...

Comment on lines +18 to +23
{%- macro generate_qos_bypass_port_list(PORT_QOS_BYPASS) %}
{# Generate list of ports #}
{%- for port_idx in range(256, 261, 4) %}
{%- if PORT_QOS_BYPASS.append("Ethernet%d" % (port_idx)) %}{%- endif %}
{%- endfor %}
{%- endmacro %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need this?

Copy link

@prasoon-nexthop prasoon-nexthop Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Priority group related config is not supported on management ports, SAI throws an error. The change made in the buffers_defaults_t2.j2 is to skip programming it on those ports.
Error thrown by SAI

SAI_API_PORT:brcm_sai_set_port_attribute:3764 PG config not supported, Port:257 type is MGMT port
2025 Oct 15 22:51:03.494097  ERR syncd#syncd: :- sendApiResponse: api SAI_COMMON_API_SET failed in syncd mode: SAI_STATUS_ATTR_NOT_SUPPORTED_0
2025 Oct 15 22:51:03.494119  ERR syncd#syncd: :- processQuadEvent: VID: oid:0x1000000000041 RID: oid:0x100000101

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui rlhui merged commit 744e74f into sonic-net:master Oct 31, 2025
21 checks passed
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
* add device dir for nh-5010

* add sonic-platform-modules-nexthop support for nh-5010

* more nh-5010 device dir changes

* remove eeprom utils change

* additional nh platform support changes

* macsec property and tap changes

* Update adm1266 test to use pd-plugin.json from nh-5010

* use nh_powercycle for nh platforms

* address review comments

* update top level build files

* remove spi module from pddf json

* follow-up cleanup after resolving merge conflict

* empty commit to retrigger checks

---------

Co-authored-by: Louis Maliyam <louis@nexthop.ai>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
* add device dir for nh-5010

* add sonic-platform-modules-nexthop support for nh-5010

* more nh-5010 device dir changes

* remove eeprom utils change

* additional nh platform support changes

* macsec property and tap changes

* Update adm1266 test to use pd-plugin.json from nh-5010

* use nh_powercycle for nh platforms

* address review comments

* update top level build files

* remove spi module from pddf json

* follow-up cleanup after resolving merge conflict

* empty commit to retrigger checks

---------

Co-authored-by: Louis Maliyam <louis@nexthop.ai>
Signed-off-by: Feng Pan <fenpan@microsoft.com>
xwjiang-ms pushed a commit to xwjiang-ms/sonic-buildimage that referenced this pull request Dec 22, 2025
* add device dir for nh-5010

* add sonic-platform-modules-nexthop support for nh-5010

* more nh-5010 device dir changes

* remove eeprom utils change

* additional nh platform support changes

* macsec property and tap changes

* Update adm1266 test to use pd-plugin.json from nh-5010

* use nh_powercycle for nh platforms

* address review comments

* update top level build files

* remove spi module from pddf json

* follow-up cleanup after resolving merge conflict

* empty commit to retrigger checks

---------

Co-authored-by: Louis Maliyam <louis@nexthop.ai>
Signed-off-by: xiaweijiang <xiaweijiang@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants