Skip to content

Add open telemetry into sonic-mgmt container.#23855

Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom
r12f:user/riffjiang/mgmt-docker
Sep 13, 2025
Merged

Add open telemetry into sonic-mgmt container.#23855
StormLiangMS merged 1 commit intosonic-net:masterfrom
r12f:user/riffjiang/mgmt-docker

Conversation

@r12f
Copy link
Contributor

@r12f r12f commented Aug 31, 2025

Why I did it

In order to enable telemetry framework in sonic-mgmt, we will need the open telemetry packages in the sonic-mgmt container:

sonic-net/sonic-mgmt#20387

Work item tracking
  • Microsoft ADO (number only):

How I did it

Updated the Dockerfile.j2.

How to verify it

Validated by manually install the packages into the mgmt container and run the scripts.

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@r12f r12f requested a review from lguohan as a code owner August 31, 2025 00:17
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@r12f
Copy link
Contributor Author

r12f commented Sep 11, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 23855 in repo sonic-net/sonic-buildimage

@r12f
Copy link
Contributor Author

r12f commented Sep 11, 2025

Hi @StormLiangMS , I wonder if you could help me trigger another azp run? : (

@bingwang-ms
Copy link
Contributor

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 6074ec5 into sonic-net:master Sep 13, 2025
20 checks passed
@wangxin
Copy link
Contributor

wangxin commented Sep 18, 2025

@r12f

This PR caused dependency conflicts while building docker-sonic-mgmt.

opentelemetry-exporter-otlp-proto-grpc 1.33.1 requires grpcio<2.0.0,>=1.63.2
opentelemetry-proto 1.33.1 requires protobuf<6.0,>=5.0

snappi 1.27.1 requires grpcio~=1.59.0;
snappi 1.27.1 requires protobuf~=4.24.4;

If install the opentelemetry packages after snappi, it will update grpcio=1.70.0, protobuf=5.29.5.

It could break the snappi package. Can we revert this change until there is a better solution?

@r12f
Copy link
Contributor Author

r12f commented Sep 18, 2025

Sure thing!

@r12f
Copy link
Contributor Author

r12f commented Sep 18, 2025

Sure thing.

@r12f
Copy link
Contributor Author

r12f commented Sep 23, 2025

Hi @wangxin , looks like we are missing this PR: #23766.

@r12f
Copy link
Contributor Author

r12f commented Oct 4, 2025

Proposed fix for this issue: #24211.

@wangxin

FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
Why I did it
In order to enable telemetry framework in sonic-mgmt, we will need the open telemetry packages in the sonic-mgmt container:

sonic-net/sonic-mgmt#20387

Work item tracking
Microsoft ADO (number only):
How I did it
Updated the Dockerfile.j2.

How to verify it
Validated by manually install the packages into the mgmt container and run the scripts.

Signed-off-by: Feng Pan <fenpan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants