Skip to content

[Arista SKUs] Enable kdump by default#23787

Merged
rlhui merged 1 commit intosonic-net:masterfrom
ymd-arista:enable_kdump_by_default
Aug 29, 2025
Merged

[Arista SKUs] Enable kdump by default#23787
rlhui merged 1 commit intosonic-net:masterfrom
ymd-arista:enable_kdump_by_default

Conversation

@ymd-arista
Copy link
Contributor

@ymd-arista ymd-arista commented Aug 22, 2025

This change does two things:

  1. Fixes inadvertent inheriting of 'crashkernel=' parameter when eos2sonic script is used for converting a device from Eos to SONiC. This makes sure that we are not working with old kdump configuration as constraints on SONiC maybe different from EOS.

  2. Adds 'crashkernel=' parameter to cmdline, which enables kdump by default when the system boots up.

on LC

admin@cmp206-5:~$ show reboot history
Name                 Cause                                                                                   Time    User    Comment
-------------------  --------------------------------------------------------------------------------------  ------  ------  -------------------------------------------------------------------------------------------------------------------------------
2025_08_22_21_32_07  Hardware - Other (gpi-2, description: gpi 2 detailed fault, time: 2025-08-22 21:25:00)  N/A     N/A     Unknown (First boot of SONiC version branch.master-ars.ec880b58-buildimage.origin.master-review.485836.16-dbg-2025.08.22.02.31)
admin@cmp206-5:~$ show kdump config
Kdump administrative mode: Enabled     <-------
Kdump operational mode: Ready
Kdump memory reservation: 0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-16G:448M,16G-32G:768M,32G-:1G
Maximum number of Kdump files: 3
Kdump ssh connection string and ssh_path not found

on supervisor

admin@cmp206:~$ show reboot history
Name                 Cause                                                                                             Time    User    Comment
-------------------  ------------------------------------------------------------------------------------------------  ------  ------  -------------------------------------------------------------------------------------------------------------------------------
2025_08_22_21_19_36  Power Loss (powerloss, description: mon 9 detailed fault - powerloss, time: 2025-08-22 21:09:36)  N/A     N/A     Unknown (First boot of SONiC version branch.master-ars.ec880b58-buildimage.origin.master-review.485836.16-dbg-2025.08.22.02.31)
admin@cmp206:~$
admin@cmp206:~$ show kdump config
Kdump administrative mode: Enabled                <-------
Kdump operational mode: Ready
Kdump memory reservation: 0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-16G:448M,16G-32G:768M,32G-:1G
Maximum number of Kdump files: 3
Kdump ssh connection string and ssh_path not found

This removes the need to do additional reboot to get kdump to operationally ready state.

Why I did it

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

  1. SONiC -> SONiC image: On the DUT running SONiC without these changes and having kdump disabled, re-sanitized it with SONiC image containing these changes.

  2. EOS -> SONiC image: Used the eos2sonic script to convert DUT from EOS to SONiC. Verified that it doesn't inherit EOS crashkernel parameters and boots up with default parameters from these changes.

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

This change does two things:

1. Fixes inadvertent inheriting of 'crashkernel=' parameter when
eos2sonic script is used for converting a device from Eos to SONiC.
This makes sure that we are not working with old kdump configuration
as constraints on SONiC maybe different from EOS.

2. Adds 'crashkernel=' parameter to cmdline, which enables kdump by
default when the system boots up.

Signed-off-by: Mohan Yelugoti <ymd@arista.com>
@ymd-arista ymd-arista requested a review from lguohan as a code owner August 22, 2025 21:50
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@kenneth-arista
Copy link
Collaborator

@ymd-arista ymd-arista changed the title Enable kdump by default [Arista SKU] Enable kdump by default Aug 22, 2025
@ymd-arista ymd-arista changed the title [Arista SKU] Enable kdump by default [Arista SKUs] Enable kdump by default Aug 22, 2025
Copy link
Contributor

@deepak-singhal0408 deepak-singhal0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deepak-singhal0408
Copy link
Contributor

MSFT ADO:33992003

@deepak-singhal0408
Copy link
Contributor

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm pushed a commit to Azure/sonic-buildimage-msft that referenced this pull request Aug 27, 2025
<!--
Please make sure you've read and understood our contributing guidelines:
     https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md

** Make sure all your commits include a signature generated with `git
commit -s` **

If this is a bug fix, make sure your description includes "fixes #xxxx",
or
     "closes #xxxx" or "resolves #xxxx"

     Please provide the following information:
-->

#### Why I did it
cherry pick PR.. Master PR:
sonic-net/sonic-buildimage#23787
##### Work item tracking
- Microsoft ADO **(number only)**:
33992003

#### How I did it
Please refer Master PR:
sonic-net/sonic-buildimage#23787
#### How to verify it
Please refer Master PR:
sonic-net/sonic-buildimage#23787
<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->

#### Which release branch to backport (provide reason below if selected)

<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->

- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211

#### Tested branch (Please provide the tested image version)

<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->

- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->

#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->

<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->

#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->

#### A picture of a cute animal (not mandatory but encouraged)
@ymd-arista
Copy link
Contributor Author

/azpw run Azure.sonic-buildimage

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rlhui rlhui merged commit 08acf9f into sonic-net:master Aug 29, 2025
20 checks passed
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to msft-202503: Azure/sonic-buildimage-msft#1565

@judyjoseph
Copy link
Contributor

@ymd-arista @Staphylo can we enable this kdump for all Arista platforms including pizza boxes ?

@ymd-arista
Copy link
Contributor Author

@judyjoseph : Yes. We have a PR to do that at #23842.

FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
This change does two things:

1. Fixes inadvertent inheriting of 'crashkernel=' parameter when
eos2sonic script is used for converting a device from Eos to SONiC.
This makes sure that we are not working with old kdump configuration
as constraints on SONiC maybe different from EOS.

2. Adds 'crashkernel=' parameter to cmdline, which enables kdump by
default when the system boots up.

Signed-off-by: Mohan Yelugoti <ymd@arista.com>
Signed-off-by: Feng Pan <fenpan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

8 participants