Add telemetry-watchdog container implementation for KubeSonic rollout#23724
Add telemetry-watchdog container implementation for KubeSonic rollout#23724qiluo-msft merged 9 commits intosonic-net:masterfrom
Conversation
FengPan-Frank
requested review from
lguohan,
qiluo-msft and
xumia
as code owners
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
telemetry_watchdog
branch
from
8f541c4 to
df41863
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
telemetry_watchdog
branch
from
df41863 to
c22f82f
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
force-pushed
the
telemetry_watchdog
branch
from
c22f82f to
11ff5c7
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FengPan-Frank
changed the title
| @@ -0,0 +1,50 @@ | |||
| {% from "dockers/dockerfile-macros.j2" import install_debian_packages, install_python_wheels, copy_files %} | |||
| ARG BASE=docker-config-engine-bookworm-{{DOCKER_USERNAME}}:{{DOCKER_USERTAG}} | |||
|
|
|||
There was a problem hiding this comment.
this still uses sonic as the base image so the image size won't be small - can we avoid it?
There was a problem hiding this comment.
if not let's make sure we use the same base for watchdog as telemetry.
There was a problem hiding this comment.
the docker image is not large for telemetry-watchdog.
There was a problem hiding this comment.
this doesn't show the shared image size - 270M is huge...
There was a problem hiding this comment.
we expect all the containers using sonic as base to share the base, which is roughly 200M to 300M, and each container itself uses less than 100M
why don't use the same base as telemetry?
There was a problem hiding this comment.
from the screenshot, seems all current watchdog has the same size, like auditd-watchdog, gnmi-watchdog..
There was a problem hiding this comment.
let's have a chat on this today when you're available.
There was a problem hiding this comment.
I double checked that actually the unique size is only 1MB for telemetry-watchdog, most are shared storage.
| Ok(c) => c, | ||
| Err(e) => { | ||
| eprintln!("Redis client error (port): {e}"); | ||
| return 50051; |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| } | ||
|
|
||
| fn get_gnmi_port() -> u16 { | ||
| let client = match redis::Client::open("redis://127.0.0.1:6379/4") { |
There was a problem hiding this comment.
Any project is using that now, could you pls give a pointer?
There was a problem hiding this comment.
#23821, I created an issue for tracking this change later, could we merge this PR first for internal image generation?
|
Cherry-pick PR to msft-202412: Azure/sonic-buildimage-msft#1687 |
|
Manual 202412 PR here: Azure/sonic-buildimage-msft#1697 |
r12f
added
Included in msft-202412 Branch
and removed
Created PR to msft-202412 Branch
labels
…sonic-net#23724) Why I did it To implement KubeSonic Design https://github.com/sonic-net/SONiC/blob/ce3ffda18399add1435cb18299c267733dcc2b38/doc/kubernetes/k8s_migration_design.md Work item tracking Microsoft ADO (number only):34506286 How I did it Implement watchdog in rust Signed-off-by: Feng Pan <[email protected]>
6 participants
Why I did it
To implement KubeSonic Design https://github.com/sonic-net/SONiC/blob/ce3ffda18399add1435cb18299c267733dcc2b38/doc/kubernetes/k8s_migration_design.md
Work item tracking
How I did it
Implement watchdog in rust
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)