[Mellanox] Stop SDK monitor thread before syncd shutdown#23681
Merged
kperumalbfn merged 1 commit intosonic-net:masterfrom Sep 22, 2025
Merged
[Mellanox] Stop SDK monitor thread before syncd shutdown#23681kperumalbfn merged 1 commit intosonic-net:masterfrom
kperumalbfn merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stepanblyschak
approved these changes
Sep 16, 2025
bingwang-ms
approved these changes
Sep 16, 2025
Contributor
|
LGTM. The error log is also noticed in 202505 qual. |
Collaborator
Hi @bingwang-ms although the error log is not functional but it will be captured by the log analyzer and fail some test, so it sill good to cherry-pick to avoid log analyzer failure. |
Contributor
|
@yejianquan Can you please evaluate the cherry-pick request to 202505? Thanks |
Collaborator
|
Cherry-pick PR to 202505: #24079 |
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
arfeigin
pushed a commit
to arfeigin/sonic-buildimage
that referenced
this pull request
Oct 21, 2025
…hutdown (sonic-net#23681)" This reverts commit 46eafcb.
tirupatihemanth
added a commit
to tirupatihemanth/sonic-buildimage
that referenced
this pull request
Nov 20, 2025
…ic-net#23681)" This reverts commit 46eafcb.
yuazhe
pushed a commit
to yuazhe/sonic-buildimage
that referenced
this pull request
Nov 24, 2025
…nitor before syncd shutdown (sonic-net#23681)"" This reverts commit 23ef36a.
tirupatihemanth
added a commit
to tirupatihemanth/sonic-buildimage
that referenced
this pull request
Nov 25, 2025
…ic-net#23681)" This reverts commit 46eafcb.
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
…3681) [Mellanox] Stop SDK health monitor before syncd shutdown Signed-off-by: Feng Pan <fenpan@microsoft.com>
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-buildimage
that referenced
this pull request
Mar 4, 2026
…utdown (sonic-net#23681) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
8 tasks
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-buildimage
that referenced
this pull request
Mar 24, 2026
…utdown (sonic-net#23681) Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-buildimage
that referenced
this pull request
Mar 24, 2026
…down (sonic-net#23681)" This reverts commit 46eafcb.
volodymyrsamotiy
added a commit
to volodymyrsamotiy/sonic-buildimage
that referenced
this pull request
Mar 25, 2026
…down (sonic-net#23681)" This reverts commit 46eafcb. Signed-off-by: Volodymyr Samotiy <volodymyrs@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
To avoid error message is syslog during shutdown flow related to SDK monitor thread.
Error message was observed only during shutdown flow, hence there was no functional impact, just error log.
It was not always reproducible because the reason for it was race condition related to monitor thread.
Work item tracking
How I did it
During shutdown flow stop SDK monitor thread before actual SDK shutdown in order to avoid race condition.
How to verify it
By running any type of reboot or config reload
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)