[otel container]: Create otel container for HFT#23666
[otel container]: Create otel container for HFT#23666kperumalbfn merged 44 commits intosonic-net:masterfrom
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6bef7de to
e991299
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
This PR adds OpenTelemetry (OTEL) collector support to the system by introducing a new docker-sonic-otel container. The OTEL collector enables telemetry data collection and export for High Fidelity Telemetry (HFT) support.
- Introduces new
docker-sonic-otelcontainer with configuration and build files - Updates service health checker to handle OTEL container conditionally based on image availability
- Adds build system variables and configuration for conditional OTEL inclusion
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/system-health/health_checker/service_checker.py | Adds conditional check to skip OTEL container health check when image is not present |
| slave.mk | Adds OTEL build variables and removes trailing whitespace |
| rules/docker-otel.mk | Defines build rules and configuration for the OTEL docker container |
| rules/docker-otel.dep | Defines build dependencies for the OTEL docker container |
| rules/config | Enables OTEL by default with INCLUDE_SYSTEM_OTEL=y |
| files/build_templates/init_cfg.json.j2 | Registers OTEL as a feature in initial config |
| dockers/docker-sonic-otel/supervisord.conf | Configures supervisord for OTEL container processes |
| dockers/docker-sonic-otel/start.sh | Container startup script |
| dockers/docker-sonic-otel/otel_vars.j2 | OTEL collector configuration template |
| dockers/docker-sonic-otel/otel.sh | Script to generate config and start OTEL collector |
| dockers/docker-sonic-otel/critical_processes | Defines critical processes for OTEL container |
| dockers/docker-sonic-otel/base_image_files/monit_otel | Monit configuration for OTEL container memory monitoring |
| dockers/docker-sonic-otel/Dockerfile.j2 | Dockerfile template for building OTEL container image |
| Makefile.work | Adds OTEL build variable to build instruction |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1d47ea8 to
e991299
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@Janetxxx could you check the copilot comments and resolve them. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/azp run Azure.sonic-buildimage |
|
@kperumalbfn I've checked Copilot's comments and marked them as resolved. Thanks. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 18 out of 18 changed files in this pull request and generated 8 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Cherry-pick PR to 202511: #25155 |
|
Pick to 202412: Azure/sonic-buildimage-msft#1930 |
Why I did it
This PR adds OpenTelemetry (OTEL) collector support to the system by introducing a new docker-sonic-otel container. The OTEL collector enables telemetry data collection and export for High Frequency Telemetry (HFT) support.
Work item tracking
How I did it
How to verify it
Run
sudo config feature state otel enabledto enable the otel collector feature, and tested it on KVM T0 testbed (ceos neighbor deployed).Checked otel container:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)