You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The create image stage in nvidia-bluefield build is failing in the pipeline due to updates to how packages are handled in the staged build (some files are deleted which are not used- documentation, lintian etc) so, create_sonic_image command fails. The fix is to basically log an error and continue the build when file is not present (it is not an error because these files are not required for the final image)
This is the PR after which the issue was seen in create_sonic_image script: #23164
After the PR was merged the following files are removed before the create_sonic_image script call:
Which contains the files from grub2-common and grub-efi-arm64-bin packages being copied in the create_sonic_image.
Since the files are removed, the error is seen. After supressing the error to just a log the following files are the ones causing issue:
To expand on the description, the change in the linked PR was intended to only affect the docker containers. However, the post_run_cleanup script gets executed on the base image itself via collect_host_image_version_files.sh, which gets called in build_debian.sh. post_run_cleanup was updated to actually remove unused packages, and (importantly here for this PR) remove documentation files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The create image stage in nvidia-bluefield build is failing in the pipeline due to updates to how packages are handled in the staged build (some files are deleted which are not used- documentation, lintian etc) so, create_sonic_image command fails. The fix is to basically log an error and continue the build when file is not present (it is not an error because these files are not required for the final image)
This is the PR after which the issue was seen in create_sonic_image script:
#23164
After the PR was merged the following files are removed before the create_sonic_image script call:
Which contains the files from grub2-common and grub-efi-arm64-bin packages being copied in the create_sonic_image.
Since the files are removed, the error is seen. After supressing the error to just a log the following files are the ones causing issue:
which are all man,doc and lintian related files
Before the PR was merged the files were still present and being used by the create_sonic_image script
Work item tracking
How I did it
copy_bin related failures are suppressed because some of the fiels are removed before the create_sonic_image function is called
How to verify it
Before fix:
After fix the compilation passes
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)