Initial changes for dhcp to support eth0 in a mgmt vrf by nikos-github · Pull Request #2348 · sonic-net/sonic-buildimage

nikos-github · 2018-12-05T02:40:16Z

The current changes are a no-op without putting eth0 in a vrf.

With the changes, eth0 can be placed in a vrf and on startup it will get an IP address via dhcp. IP address changes or gateway changes are correctly reflected.

Next to figure out is dns and ntp.

Nikos.-

Signed-off-by: nikos ntriantafillis@gmail.com

files/dhcp/vrf

build_debian.sh

lguohan · 2018-12-05T08:33:13Z

there is broadcom build failure, i suspect it is related ifupdown2.

nikos-github · 2018-12-05T08:56:22Z

retest this please

nikos-github · 2018-12-07T22:59:34Z

retest this please

nikos-github · 2019-01-07T08:40:57Z

@lguohan Can we please merge this?

lguohan · 2019-01-08T19:15:21Z

@nikos-github, since you did not delete the script rfc3442-classless-routes, and they both add routes, is there going to be some conflict here?

lguohan · 2019-01-08T19:20:13Z

there is no comment for the vrf script, can you provide description?

files/dhcp/vrf

nikos-github · 2019-01-08T19:53:28Z

My bad - missed your comment about the description. Will add that.

nikos-github · 2019-01-08T19:54:26Z

@nikos-github, since you did not delete the script rfc3442-classless-routes, and they both add routes, is there going to be some conflict here?

There should be no conflict here since the table_id is checked.

…dimage into mgmt-vrf

nikos-github · 2019-01-14T01:41:12Z

@lguohan Description added.

…dimage into mgmt-vrf

93af69c [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) 37349cf [swssconfig] Optimize performance of swssconfig (sonic-net#2336) 84e9b07 [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) 1b8bd94 Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) 1ed0b4b [macsec] Refactor the logic of macsec name map (sonic-net#2348) f88f992 [mock_tests] Add Sflow Orch UTs (sonic-net#2295) ec57bf1 [macsec] Update macsec flex counter (sonic-net#2338) 6e0fc85 [ACL] Support stage particular match fields (sonic-net#2341) efb4530 [orchagent, DTel]: report session support to set user vrf (sonic-net#2326) d82874d Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig sonic-net#11046" (sonic-net#2332) 0c789e6 Fix qos map test in vs test (sonic-net#2343) 1bb5070 Enhance mock test for dynamic buffer manager for port removing and qos reload flows (sonic-net#2262) 700492f [aclorch] Fix and simplify DTel watchlist tables and entries (sonic-net#2155) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions #11235 (#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

Swss commits: 93af69c [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (#2304) 37349cf [swssconfig] Optimize performance of swssconfig (#2336) 84e9b07 [fdborch] fix heap-use-after-free in clearFdbEntry() (#2353) 1b8bd94 Create ACL table fails due to incorrect check for supported ACL actions #11235 (#2351) 1ed0b4b [macsec] Refactor the logic of macsec name map (#2348) f88f992 [mock_tests] Add Sflow Orch UTs (#2295) ec57bf1 [macsec] Update macsec flex counter (#2338) 6e0fc85 [ACL] Support stage particular match fields (#2341) efb4530 [orchagent, DTel]: report session support to set user vrf (#2326) d82874d Fix for "orchagent crashed when trying to delete fdb static entry with swssconfig #11046" (#2332) 0c789e6 Fix qos map test in vs test (#2343) 1bb5070 Enhance mock test for dynamic buffer manager for port removing and qos reload flows (#2262) 700492f [aclorch] Fix and simplify DTel watchlist tables and entries (#2155) Signed-off-by: Vivek Reddy Karri <vkarri@nvidia.com>

…et#11254) swss: * ad2d0ad 2022-06-24 | [PFC_WD] Avoid applying ZeroBuffer Profiles to ingress PG when a PFC storm is detected (sonic-net#2304) (HEAD -> 202205) [Vivek R] * ef75554 2022-06-25 | [swssconfig] Optimize performance of swssconfig (sonic-net#2336) [Junchao-Mellanox] * d9e9ba8 2022-06-24 | [fdborch] fix heap-use-after-free in clearFdbEntry() (sonic-net#2353) [Yakiv Huryk] * 585a69b 2022-06-24 | Create ACL table fails due to incorrect check for supported ACL actions sonic-net#11235 (sonic-net#2351) [Ravindranath C K] * 0d19560 2022-06-24 | [macsec] Refactor the logic of macsec name map (sonic-net#2348) [Junhua Zhai] * 111dfc2 2022-06-23 | [macsec] Update macsec flex counter (sonic-net#2338) (HEAD -> 202205, github/202205) [Junhua Zhai] swss-common: * 0213d55 2022-06-23 | [portcounter] Check if counter ID exists before arithmetic operation (sonic-net#632) (HEAD -> 202205, github/202205) [Junhua Zhai] * c21c47e 2022-06-14 | [counter] Add counter table (sonic-net#622) [Junhua Zhai] utilities: * 430cd65 2022-06-23 | [202205] [generate dump] Move the Core/Log collection to the End of process Execution and removed default timeout (sonic-net#2230) (github/202205) [Vivek R] linkmgrd: * 59334be 2022-06-24 | Remove exception throwing when initializing missing loopback interface (sonic-net#90) (HEAD -> 202205) [Jing Zhang] Signed-off-by: Ying Xie <ying.xie@microsoft.com>

* Add/remove macsec name map w/o gearbox correctly * Add macsec counter unit test

Initial changes to support eth0 in a mgmt vrf

a6a7a73

nikos-github changed the title ~~Initial changes to support eth0 in a mgmt vrf~~ Initial changes for dhcp to support eth0 in a mgmt vrf Dec 5, 2018

lguohan reviewed Dec 5, 2018

View reviewed changes

files/dhcp/vrf Show resolved Hide resolved

lguohan reviewed Dec 5, 2018

View reviewed changes

build_debian.sh Show resolved Hide resolved

lguohan reviewed Dec 5, 2018

View reviewed changes

build_debian.sh Show resolved Hide resolved

stcheng added the Enhancement ➕ label Dec 5, 2018

nikos added 4 commits December 6, 2018 18:50

Initial changes to support eth0 in a mgmt vrf

e3bbf9c

Initial changes for dhcp to support eth0 in a mgmt vrf

d0d3514

Initial changes for dhcp to support eth0 in a mgmt vrf

04b5f64

Remove aboot check as it's not needed anymore with ifupdown2

21d13cc

nikos-github mentioned this pull request Jan 7, 2019

management vrf using vrf function of new kernel #2411

Closed

lguohan reviewed Jan 8, 2019

View reviewed changes

files/dhcp/vrf Show resolved Hide resolved

lguohan reviewed Jan 8, 2019

View reviewed changes

files/dhcp/vrf Show resolved Hide resolved

nikos added 2 commits January 13, 2019 17:38

Add dhclient exit hook description and license info.

0719225

Merge branch 'mgmt-vrf' of https://github.com/nikos-github/sonic-buil…

5970ed9

…dimage into mgmt-vrf

nikos added 2 commits January 14, 2019 09:13

Merge branch 'mgmt-vrf' of https://github.com/nikos-github/sonic-buil…

60044ee

…dimage into mgmt-vrf

Merge branch 'mgmt-vrf' of https://github.com/nikos-github/sonic-buil…

56aef27

…dimage into mgmt-vrf

svc-acs approved these changes Jan 16, 2019

View reviewed changes

lguohan approved these changes Jan 16, 2019

View reviewed changes

lguohan merged commit e55a7d7 into sonic-net:master Jan 16, 2019

nikos-github deleted the mgmt-vrf branch January 16, 2019 17:24

yxieca mentioned this pull request Jun 25, 2022

[202205][swss][swss-common][linkmgrd] advance submodule head #11254

Merged

vivekrnv pushed a commit to vivekrnv/sonic-buildimage that referenced this pull request Aug 26, 2022

[macsec] Refactor the logic of macsec name map (sonic-net#2348)

1ed0b4b

* Add/remove macsec name map w/o gearbox correctly * Add macsec counter unit test

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial changes for dhcp to support eth0 in a mgmt vrf#2348

Initial changes for dhcp to support eth0 in a mgmt vrf#2348
lguohan merged 9 commits intosonic-net:masterfrom
nikos-github:mgmt-vrf

nikos-github commented Dec 5, 2018 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lguohan commented Dec 5, 2018

Uh oh!

nikos-github commented Dec 5, 2018

Uh oh!

nikos-github commented Dec 7, 2018

Uh oh!

nikos-github commented Jan 7, 2019

Uh oh!

lguohan commented Jan 8, 2019

Uh oh!

lguohan commented Jan 8, 2019

Uh oh!

Uh oh!

Uh oh!

nikos-github commented Jan 8, 2019

Uh oh!

nikos-github commented Jan 8, 2019

Uh oh!

nikos-github commented Jan 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

nikos-github commented Dec 5, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lguohan commented Dec 5, 2018

Uh oh!

nikos-github commented Dec 5, 2018

Uh oh!

nikos-github commented Dec 7, 2018

Uh oh!

nikos-github commented Jan 7, 2019

Uh oh!

lguohan commented Jan 8, 2019

Uh oh!

lguohan commented Jan 8, 2019

Uh oh!

Uh oh!

Uh oh!

nikos-github commented Jan 8, 2019

Uh oh!

nikos-github commented Jan 8, 2019

Uh oh!

nikos-github commented Jan 14, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

nikos-github commented Dec 5, 2018 •

edited

Loading