[Mellanox] Add common sai.profile per asic and asic_detect.sh script#23458
Merged
liat-grozovik merged 6 commits intosonic-net:masterfrom Aug 11, 2025
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liat-grozovik
approved these changes
Aug 11, 2025
Merged
9 tasks
Collaborator
|
Cherry-pick PR to 202505: #23676 |
ccroy-arista
pushed a commit
to ccroy-arista/sonic-buildimage
that referenced
this pull request
Aug 14, 2025
…onic-net#23458) - Why I did it This PR adds new script for Mellanox asic detection, as there are few places that use it. The script queries "lspci" command to find out what is the current device ID. If the script was successful, we write the value to asic_type so the script will be running only 1 time. Also, added sai-spcx.profile and sai-bf3.profile with relevant parameters. - How I did it Added new script to detect asic type, and new files for per-asic sai.profile - How to verify it Run on switch and make sure the parameters are applied to sai.profile inside syncd.
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
liat-grozovik
pushed a commit
that referenced
this pull request
Sep 2, 2025
…tect.sh script (#23871) - Why I did it asic_detect.sh script was added in this PR - #23458. It uses lspci command, which can be used only if pciutils package is installed. Syncd docker started to use asic_detect.sh script by this PR - sonic-net/sonic-sairedis#1633 So, syncd of Mellanox and nvidia-bluefield must have pciutils installed. - How I did it Added pciutils installation in syncd Dockerfile - How to verify it Make sure pciutils package is installed in Mellanox switch syncd docker
mssonicbld
added a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 3, 2025
…tect.sh script
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "fixes #xxxx", or
"closes #xxxx" or "resolves #xxxx"
Please provide the following information:
-->
#### Why I did it
asic_detect.sh script was added in this PR - sonic-net#23458.
It uses lspci command, which can be used only if pciutils package is installed.
Syncd docker started to use asic_detect.sh script by this PR - sonic-net/sonic-sairedis#1633
So, syncd of Mellanox and nvidia-bluefield must have pciutils installed.
##### Work item tracking
- Microsoft ADO **(number only)**:
#### How I did it
Added pciutils installation in syncd Dockerfile
#### How to verify it
Make sure pciutils package is installed in Mellanox switch syncd docker
<!--
If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012.
-->
#### Which release branch to backport (provide reason below if selected)
<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [ ] 202205
- [ ] 202211
- [ ] 202305
- [ ] 202311
- [ ] 202405
- [ ] 202411
- [ ] 202505
#### Tested branch (Please provide the tested image version)
<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->
- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->
#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
-->
#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->
#### A picture of a cute animal (not mandatory but encouraged)
9 tasks
mssonicbld
added a commit
that referenced
this pull request
Sep 3, 2025
…tect.sh script (#23885) <!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "fixes #xxxx", or "closes #xxxx" or "resolves #xxxx" Please provide the following information: --> #### Why I did it asic_detect.sh script was added in this PR - #23458. It uses lspci command, which can be used only if pciutils package is installed. Syncd docker started to use asic_detect.sh script by this PR - sonic-net/sonic-sairedis#1633 So, syncd of Mellanox and nvidia-bluefield must have pciutils installed. ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Added pciutils installation in syncd Dockerfile #### How to verify it Make sure pciutils package is installed in Mellanox switch syncd docker <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 202205 - [ ] 202211 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> - [ ] <!-- image version 1 --> - [ ] <!-- image version 2 --> #### Description for the changelog <!-- Write a short (one line) summary that describes the changes in this pull request for inclusion in the changelog: --> <!-- Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU. --> #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
…onic-net#23458) - Why I did it This PR adds new script for Mellanox asic detection, as there are few places that use it. The script queries "lspci" command to find out what is the current device ID. If the script was successful, we write the value to asic_type so the script will be running only 1 time. Also, added sai-spcx.profile and sai-bf3.profile with relevant parameters. - How I did it Added new script to detect asic type, and new files for per-asic sai.profile - How to verify it Run on switch and make sure the parameters are applied to sai.profile inside syncd. Signed-off-by: Feng Pan <fenpan@microsoft.com>
FengPan-Frank
pushed a commit
to FengPan-Frank/sonic-buildimage
that referenced
this pull request
Dec 4, 2025
…tect.sh script (sonic-net#23871) - Why I did it asic_detect.sh script was added in this PR - sonic-net#23458. It uses lspci command, which can be used only if pciutils package is installed. Syncd docker started to use asic_detect.sh script by this PR - sonic-net/sonic-sairedis#1633 So, syncd of Mellanox and nvidia-bluefield must have pciutils installed. - How I did it Added pciutils installation in syncd Dockerfile - How to verify it Make sure pciutils package is installed in Mellanox switch syncd docker Signed-off-by: Feng Pan <fenpan@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR adds new script for Mellanox asic detection, as there are few places that use it.
The script queries "lspci" command to find out what is the current device ID.
If the script was successful, we write the value to asic_type so the script will be running only 1 time.
Also, added sai-spcx.profile and sai-bf3.profile with relevant parameters.
How I did it
Added new script to detect asic type, and new files for per-asic sai.profile
How to verify it
Run on switch and make sure the parameters are applied to sai.profile inside syncd.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)