Skip to content

[action] [PR:21849] Improve GNMI_CLIENT_CERT table to support multiple roles. #23449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mssonicbld merged 1 commit into from
Jul 24, 2025
Merged

[action] [PR:21849] Improve GNMI_CLIENT_CERT table to support multiple roles. #23449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/sonic-yang-models/tests/files/sample_config_db.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1338,10 +1338,14 @@
},
"GNMI_CLIENT_CERT": {
"testcert1": {
"role": "RW"
"role": [
"RW"
]
},
"testcert2": {
"role": "RO"
"role": [
"RO"
]
}
},
"TUNNEL": {
Expand Down
2 changes: 1 addition & 1 deletion src/sonic-yang-models/tests/yang_model_tests/tests/gnmi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"GNMI_CLIENT_CERT_LIST_TABLE_WITH_MISSING_ROLE": {
"desc": "CLIENT_CERT_LIST_TABLE_WITH_MISSING_ROLE failure.",
"eStrKey": "Mandatory"
"eStrKey": "MinElements"
},
"GNMI_CLIENT_CERT_LIST_TABLE_WITH_VALID_CONFIG": {
"desc": "TABLE WITH VALID CONFIG."
Expand Down
8 changes: 6 additions & 2 deletions src/sonic-yang-models/tests/yang_model_tests/tests_config/gnmi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,11 +80,15 @@
"GNMI_CLIENT_CERT_LIST": [
{
"cert_cname": "testcert1",
"role": "RW"
"role": [
"RW"
]
},
{
"cert_cname": "testcert2",
"role": "RO"
"role": [
"RO"
]
}
]
}
Expand Down
4 changes: 2 additions & 2 deletions src/sonic-yang-models/yang-models/sonic-gnmi.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,9 @@ module sonic-gnmi {
"client cert common name";
}

leaf role {
leaf-list role {
type string;
mandatory true;
min-elements 1;
description
"role of client cert common name";
}
Expand Down
Loading