Add DHCP hook to set static hostname after getting from DHCP#230
Closed
taoyl-ms wants to merge 1 commit intosonic-net:masterfrom
Closed
Add DHCP hook to set static hostname after getting from DHCP#230taoyl-ms wants to merge 1 commit intosonic-net:masterfrom
taoyl-ms wants to merge 1 commit intosonic-net:masterfrom
Conversation
lguohan
approved these changes
Feb 1, 2017
Collaborator
|
does this work? can you test it? |
Collaborator
|
this make make the |
lguohan
reviewed
Feb 1, 2017
|
|
||
| sudo cp files/dhcp/rfc3442-classless-routes $FILESYSTEM_ROOT/etc/dhcp/dhclient-exit-hooks.d | ||
| sudo cp files/dhcp/hostname $FILESYSTEM_ROOT/etc/dhcp/dhclient-exit-hooks.d/ | ||
| sudo cp files/dhcp/rfc3442-classless-routes $FILESYSTEM_ROOT/etc/dhcp/dhclient-exit-hooks.d/ |
Collaborator
There was a problem hiding this comment.
why this line is also changed?
Contributor
Author
There was a problem hiding this comment.
just to add '/' at the end of target to specify it is a folder.
Contributor
Author
|
The current hostname needs to be localhost for this to work. When current hostname is localhost, dhclient will set the hostname in kernel, and this hook will set the /etc/hostname file according to kernel hostname. Current default hostname in base image seems to be sonic instead of localhost so it is not working. |
Contributor
Author
|
On the other hand, #235 will explicitly set both kernel hostname and /etc/hostname upon every dhcpack. So the decision on which approach to apply really depends on our goal - if we want the hostname be set only once right after deployment, we should adopt this approach, and change hostname in baseimage into localhost instead of current sonic. If we want the hostname be able to be updated even after deployment, we should adopt #235. |
Collaborator
|
The idea is that when we done with dhcp, we'll disable dhcp and set static IP based on the minigraph, no longer use dhcp any more. so I think #235 fit our need. |
Collaborator
|
let's close this one and comment on #235. |
Kalimuthu-Velappan
pushed a commit
to Kalimuthu-Velappan/sonic-buildimage
that referenced
this pull request
Sep 12, 2019
dmytroxshevchuk
pushed a commit
to dmytroxshevchuk/sonic-buildimage
that referenced
this pull request
Aug 31, 2020
* Update port and queue counters by Flex counter * [stat counters sonic-net#230] added missing removing of empty instances
lguohan
pushed a commit
that referenced
this pull request
Aug 6, 2021
Include below commits sonic-swss-common ``` 83d3351 2021-04-22 | [swig] fix ConfigDBConnector.db_name (#483) [Qi Luo] fdf296f 2021-04-09 | Fix: ConfigDBConnector call super init with proper parameter name (#470) [Qi Luo] 4f580e3 2021-03-26 | [swig] translate SonicV2Connector::keys return type from C++ vector<string> to Python list (#468) [Qi Luo] ``` sonic-snmpagent ``` c160c2b 2021-08-04 | CPU Spike because of redundant and flooded keyspace notifis handled (#230) [Vivek Reddy] a4dd3bf 2021-08-03 | Non-block reading counters to tolerate corrupted/delayed counters in COUNTERS_DB (#231) [Qi Luo] ```
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
Includes below commits: ``` 43b5e1a 2021-08-04 | CPU Spike because of redundant and flooded keyspace notifis handled (sonic-net#230) [Vivek Reddy] 4d6bb79 2021-08-02 | Non-block reading counters to tolerate corrupted/delayed counters in COUNTERS_DB (sonic-net#229) [Qi Luo] ```
judyjoseph
added a commit
that referenced
this pull request
Nov 14, 2021
sonic-snmpagent 7e46eb1 [201911][RFC1213]: Initialize lag oid map in reinit_data (#234) aa98ded CPU Spike because of redundant and flooded keyspace notifis handled (#230) sonic-swss bc4e334 [Mux orch] Handle setting unknown mux state (#1984) bd3630b [tunnel decap] Change tunnel orch order (#1977) 87a673a Fix the option missing in kernel config issue (#1973) 57967a1 [orchagent] Fix group name of port-buffer-drop in flexcounterorch.cpp (#1967) sonic-utilities 181e8b0 Fix the option missing in kernel config issue (#1888) 21c0cc0 [watermarkstat] Fix for error in processing empty array from couters db (#1810) 7f15755 [chassis][supervisor][show][interfaces]show interfaces command warning on Supervisor card (#1771)
vdahiya12
added a commit
to vdahiya12/sonic-buildimage
that referenced
this pull request
Nov 18, 2021
6f198d0 (HEAD -> 202012, origin/202012) [Y-Cable][Broadcom] upgrade to support Broadcom Y-Cable API to release (sonic-net#230) 1c3e422 SSD Health: Retrieve SSD health and temperature values from generic SSD info (sonic-net#229) Signed-off-by: vaibhav-dahiya <[email protected]>
5 tasks
lguohan
pushed a commit
that referenced
this pull request
Nov 18, 2021
6f198d0 (HEAD -> 202012, origin/202012) [Y-Cable][Broadcom] upgrade to support Broadcom Y-Cable API to release (#230) 1c3e422 SSD Health: Retrieve SSD health and temperature values from generic SSD info (#229) Signed-off-by: vaibhav-dahiya <[email protected]>
5 tasks
SuvarnaMeenakshi
pushed a commit
to SuvarnaMeenakshi/sonic-buildimage
that referenced
this pull request
Mar 16, 2022
…onic-net#230) **- What I did** Fixes [sonic-net#8293](sonic-net#8293) **- How I did it** Accumulated all the older notifications and did act only upon the latest notification discarding the others
6 tasks
snider-nokia
pushed a commit
to snider-nokia/sonic-buildimage
that referenced
this pull request
Apr 6, 2023
sonic-net#230) This release goes in sync with the following firmware version of Broadcom Y cable, which is consistent with release 7 { "version_nic_active": "D207.1.D103.1", "version_nic_inactive": "D207.1.D103.1", "version_nic_next": "D207.1.D103.1", "version_peer_active": "D307.1", "version_peer_inactive": "D307.1", "version_peer_next": "D307.1", "version_self_active": "D307.1", "version_self_inactive": "D307.1", "version_self_next": "D307.1" } Signed-off-by: vaibhav-dahiya [email protected] Description Basically a vendor specific implementation of abstract YCableBase class . detailed design discussion can be found https://github.com/Azure/SONiC/pull/757/files Signed-off-by: vaibhav-dahiya <[email protected]>
vivekrnv
pushed a commit
to vivekrnv/sonic-buildimage
that referenced
this pull request
Apr 28, 2023
Dynamic write_max support for optoe driver Signed-off-by: Prince George <[email protected]>
mssonicbld
added a commit
that referenced
this pull request
May 7, 2024
…lly (#18888) #### Why I did it src/sonic-gnmi ``` * c2bfe3d - (HEAD -> master, origin/master, origin/HEAD) Fix memory leak in unit test (#230) (44 minutes ago) [ganglv] * 16c2975 - Disable translib unit test (#229) (71 minutes ago) [ganglv] * 4c86853 - Merge pull request #224 from ganglyu/fix_build (10 hours ago) [Saikrishna Arcot] * db2d896 - Disable dialout unit test (3 days ago) [ganglyu] * 0e4ac4d - Disable translib test (4 days ago) [ganglyu] * 8494e90 - Fix unit test (4 days ago) [ganglyu] * 036979d - Fix unit test (4 days ago) [ganglyu] * bd74b09 - Disable failed unit test (4 days ago) [ganglyu] * a4bc960 - Update go.mod (7 days ago) [ganglyu] * c15d45f - Fix build error (7 days ago) [ganglyu] * 775a41e - Fix go.sum (7 days ago) [ganglyu] * b39742e - Fix build error from sonic-mgmt-common (7 days ago) [ganglyu] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Jun 21, 2025
…utomatically (#22660) #### Why I did it src/sonic-host-services ``` * 0206da1 - (HEAD -> 202505, origin/202505) Revert "[featured] fix non existing feature start (#234)" (#273) (51 minutes ago) [mssonicbld] * d4d624e - Add iptables rules to drop all bgp packets destined for loopback1 IP addresses in dual ToR (#269) (10 days ago) [mssonicbld] * 93db579 - Fix PyGObject required version (#265) (2 weeks ago) [mssonicbld] * 112acad - [build] Update Azure pipeline to use Ubuntu 24.04 image (#266) (2 weeks ago) [mssonicbld] * 1ee792e - Implement Download and Delete For File Service (#242) (5 weeks ago) [Dawei Huang] * 00393e3 - [kdump-config] Update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (#237) (7 weeks ago) [Marty Y. Lok] * d028745 - [Radius] Add require_message_authenticator option to fix BlastRadius issue. (#172) (7 weeks ago) [Julian Chang] * 8237b5d - Monitor rsyslog feature flag change and update rsyslog config by restart rsyslog-config service (#245) (7 weeks ago) [Hua Liu] * 55cee71 - Improve Detection Logic for HALT Command in is_halt_command_running() (#247) (8 weeks ago) [Vasundhara Volam] * 29b8be8 - [featured] fix non existing feature start (#234) (3 months ago) [Stepan Blyshchak] * fe90cb1 - Adding support for filtering by destination IP and/or incoming interface to caclmgrd. (#195) (3 months ago) [nyanto] * 6006e05 - caclmgrd interface rules patch 1 (#197) (3 months ago) [Nanma Purushotam] * 3ba0c59 - Pin PyGObject to 3.50.0 (#228) (3 months ago) [cpackham-atlnz] * 5445cf6 - Radius Access request to use configured src interface (#230) (3 months ago) [lakshmi-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog
mssonicbld
added a commit
that referenced
this pull request
Jun 22, 2025
…utomatically (#22160) #### Why I did it src/sonic-host-services ``` * aa971f6 - (HEAD -> master, origin/master, origin/HEAD) Revert "[featured] fix non existing feature start (#234)" (#272) (29 hours ago) [Qi Luo] * 04e49f8 - Add iptables rules to drop all bgp packets destined for loopback1 IP addresses in dual ToR (#262) (11 days ago) [Yawen] * 727e21b - [Caclmgrd]Fix key error issue about acl_source_ip_map (#268) (11 days ago) [Changrong Wu] * 4cb6b97 - Restart caclmgrd whenever catch exception in child thread or in main thread (#194) (13 days ago) [Zhaohui Sun] * d7842aa - config_db should not mandate True and False for featured (#252) (2 weeks ago) [Brad House - NextHop] * 70de4d1 - Fix PyGObject required version (#264) (3 weeks ago) [Qi Luo] * 953816b - Modify cacl rules to allow incoming packets to dash-ha (#256) (3 weeks ago) [yue-fred-gao] * 5460c29 - Improve reboot status tracking and add reboot count & method to status (#259) (3 weeks ago) [Vasundhara Volam] * e46e36e - Update ubuntu version in azure pipeline (#260) (4 weeks ago) [Vasundhara Volam] * 23b81f9 - Fix reboot without message (#250) (4 weeks ago) [jkmar] * 1ee792e - Implement Download and Delete For File Service (#242) (5 weeks ago) [Dawei Huang] * 00393e3 - [kdump-config] Update kdump default config with pre-defined value in /proc/cmdline (installer.conf) (#237) (7 weeks ago) [Marty Y. Lok] * d028745 - [Radius] Add require_message_authenticator option to fix BlastRadius issue. (#172) (7 weeks ago) [Julian Chang] * 8237b5d - Monitor rsyslog feature flag change and update rsyslog config by restart rsyslog-config service (#245) (8 weeks ago) [Hua Liu] * 55cee71 - Improve Detection Logic for HALT Command in is_halt_command_running() (#247) (8 weeks ago) [Vasundhara Volam] * 29b8be8 - [featured] fix non existing feature start (#234) (3 months ago) [Stepan Blyshchak] * fe90cb1 - Adding support for filtering by destination IP and/or incoming interface to caclmgrd. (#195) (3 months ago) [nyanto] * 6006e05 - caclmgrd interface rules patch 1 (#197) (3 months ago) [Nanma Purushotam] * 3ba0c59 - Pin PyGObject to 3.50.0 (#228) (3 months ago) [cpackham-atlnz] * 5445cf6 - Radius Access request to use configured src interface (#230) (3 months ago) [lakshmi-nexthop] ``` #### How I did it #### How to verify it #### Description for the changelog
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
…AD automatically (sonic-net#1523) #### Why I did it src/sonic-utilities ``` * 2ad821cf - (HEAD -> 202503, origin/202503) Merge pull request sonic-net#230 from mssonicbld/sonicbld/202503-merge (16 hours ago) [mssonicbld] * a71bfb52 - Merge branch '202412' of https://github.com/Azure/sonic-utilities.msft into 202503 (16 hours ago) [Sonic Automation] * 8642b394 - [202412][trim]: Add Packet Trimming Drop Counters CLI (sonic-net#227) (2 days ago) [Nazarii Hnydyn] ``` #### How I did it #### How to verify it #### Description for the changelog
jianyuewu
pushed a commit
to jianyuewu/sonic-buildimage
that referenced
this pull request
Feb 10, 2026
Fixes Issue: sonic-net#21386 Why I did it When authentication is triggered by the DUT, source interface configured under radius needs to be used for sending access request. How I did it config db needs to be looked up for the source interface from the radius config and store the IP address of this interface in the pam_radius_auth file. How to verify: Configured AAA authentication, configured radius with source interface as uplink port channel. tb1@sonic:~$ sudo config aaa authentication login radius local tb1@sonic:~$ sudo config radius add -s PortChannel100 -k test -p 3 10.120.20.1 initiate ssh into the dut. this triggers radius auth request access request is sent out with port channel ip address as source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.