Fix typo in pddf_current_sensor constructor#22997
Merged
Praveen-Brcm merged 1 commit intosonic-net:masterfrom Jul 9, 2025
Merged
Fix typo in pddf_current_sensor constructor#22997Praveen-Brcm merged 1 commit intosonic-net:masterfrom
Praveen-Brcm merged 1 commit intosonic-net:masterfrom
Conversation
Line sonic-net#27 self.display_name = self.sensor_data should be self.display_name = self.sensor_obj
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Contributor
|
@Praveen-Brcm @FuzailBrcm @geans-pin Please take a look, thanks! |
geans-pin
approved these changes
Jun 25, 2025
Contributor
|
Hi @Praveen-Brcm could you help merge? Thank you! |
Praveen-Brcm
approved these changes
Jul 9, 2025
YairRaviv
pushed a commit
to YairRaviv/sonic-buildimage
that referenced
this pull request
Jul 15, 2025
Line sonic-net#27 self.display_name = self.sensor_data should be self.display_name = self.sensor_obj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Line #27 self.display_name = self.sensor_data should be self.display_name = self.sensor_obj
See https://github.com/sonic-net/sonic-buildimage/pull/22444/files#r2142117886 for reference.
Fixes #22996
Work item tracking
How I did it
Incorporate review comment feedback
How to verify it
Add pddf_current_sensor in a pddf-device.json file
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)