Add tuning file to Quicksilver platforms#22956
Add tuning file to Quicksilver platforms#22956kewei-arista wants to merge 5 commits intosonic-net:masterfrom
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
prgeor
left a comment
prgeor
left a comment
There was a problem hiding this comment.
@kewei-arista I am not sure where is this key formed for LPO?
LPO100
``
This is just a placeholder key for LPO. Depending on the actual LPO modules used, this can be updated to match part number. |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kewei-arista
force-pushed
the
pr-master-th5.1
branch
from
3e56e8e to
3bbd40e
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Rebased the commits to remove |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
hi @prgeor , any update on this PR review? |
|
checked with Prince and this PR is not needed in 202412 anymore. removing 202412 tag. |
@kewei-arista are these settings applicable for any retimed and non-retimed optics? |
@prgeor These settings are only applicable for retimed optics? For non-retimed optics like LPO, we may need different values. |
kewei-arista
force-pushed
the
pr-master-th5.1
branch
from
b2e04e6 to
2b2004a
Compare
|
/azp run Azure.sonic-buildimage |
|
/azp run Azure.sonic-buildimage |
1 similar comment
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sure done |
|
hi @kewei-arista could you check the conflict? |
kewei-arista
force-pushed
the
pr-master-th5.1
branch
from
ee500d5 to
ce68a2c
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kewei-arista
force-pushed
the
pr-master-th5.1
branch
from
ce68a2c to
2a9e040
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: kewei <[email protected]>
Signed-off-by: kewei <[email protected]>
Signed-off-by: kewei <[email protected]>
kewei-arista
force-pushed
the
pr-master-th5.1
branch
from
2a9e040 to
ff80bad
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
@StormLiangMS I have resolved the conflicts but the build failed with |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
6 participants
Why I did it
These tuning values provide better signal integrity and link quality compared to the default tuning values in the Fairwater optic testing. Submitting these values for an improved link performance, especially for 100G rate retimed optics.
Work item tracking
How I did it
Convert the values from our HW engineers into the json file that's accepted by SONiC.
How to verify it
Confirmed that new tuning values are applied to the ports correctly based on the inserted media types, also verified better performance with these values in Fairwater optic testing.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)