You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The sonic-utilities-data_1.0-1_all.deb target depends on sources from the src/sonic-utilities submodule. However, the cache dependency file does not list this submodule as a dependency. So, when the build cache is used, updates to the src/sonic-utilities submodule pointer do not trigger the necessary rebuild of sonic-utilities-data_1.0-1_all.deb, leading to a stale build output.
Work item tracking
Microsoft ADO (number only):
How I did it
Updated rules/sonic-utilities-data.dep to include the proper SMDEP rules.
How to verify it
Perform a build with the dpkg cache enabled
Confirm the new output file target/debs/bookworm/sonic-utilities-data_1.0-1_all.deb.smdep is created, containing the submodule dependencies (smdeps)
Archive the target/debs/bookworm/sonic-utilities-data_1.0-1_all.deb output outside the build workspace
Clean the build workspace
Update the src/sonic-utilities submodule pointer to a new commit that contains different source code
Perform another build with the dpkg cache enabled
Extract the previous and current sonic-utilities-data_1.0-1_all.deb outputs. Confirm that the contents of the debian packages are distinct and contain the expected source based on the respective src/sonic-utilities submodule pointers
Which release branch to backport (provide reason below if selected)
202405
202411
202505
This is a build bug which silently results in incorrect build outputs when the dpkg cache is used. As such, it should be double committed.
Tested branch (Please provide the tested image version)
@qiluo-msft thanks for the approval. Looks like the kvmtests have all failed due to timeout. I think this is unlikely to be related to this change. Is there any known issue? Should we rerun them?
@qiluo-msft thanks for the approval. Looks like the kvmtests have all failed due to timeout. I think this is unlikely to be related to this change. Is there any known issue? Should we rerun them?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
Why I did it
The
sonic-utilities-data_1.0-1_all.debtarget depends on sources from thesrc/sonic-utilitiessubmodule. However, the cache dependency file does not list this submodule as a dependency. So, when the build cache is used, updates to thesrc/sonic-utilitiessubmodule pointer do not trigger the necessary rebuild ofsonic-utilities-data_1.0-1_all.deb, leading to a stale build output.Work item tracking
How I did it
Updated
rules/sonic-utilities-data.depto include the properSMDEPrules.How to verify it
target/debs/bookworm/sonic-utilities-data_1.0-1_all.deb.smdepis created, containing the submodule dependencies (smdeps)target/debs/bookworm/sonic-utilities-data_1.0-1_all.deboutput outside the build workspacesrc/sonic-utilitiessubmodule pointer to a new commit that contains different source codesonic-utilities-data_1.0-1_all.deboutputs. Confirm that the contents of the debian packages are distinct and contain the expected source based on the respectivesrc/sonic-utilitiessubmodule pointersWhich release branch to backport (provide reason below if selected)
This is a build bug which silently results in incorrect build outputs when the dpkg cache is used. As such, it should be double committed.
Tested branch (Please provide the tested image version)
Description for the changelog
Fix submodule build dependency for sonic-utilities-data
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)