[sonic-package-manager] Use tag to start application#22911
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Jul 21, 2025
Merged
[sonic-package-manager] Use tag to start application#22911qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
stepanblyschak
approved these changes
Jun 12, 2025
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This is done in order to be able to start using tag which will provide a user-friendly identifier when running docker ps.
DavidZagury
force-pushed
the
master_fix_app_extension_instllation
branch
from
651d03a to
55c92e6
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Jul 14, 2025
| -v /var/run/docker-syncd$DEV:/var/run/sswsyncd \ | ||
| "docker-$GBSYNCD_PLATFORM":latest \ | ||
| {%- elif docker_image_tag is defined and docker_image_tag is not none %} | ||
| {{docker_image_tag}} \ |
Collaborator
Contributor
Author
There was a problem hiding this comment.
@qiluo-msft , docker_image_tag already contains the full name used to install the docker image.
For example, in dhcp-relay it would contain "docker-dhcp-relay:latest"
Collaborator
There was a problem hiding this comment.
This is confusing. Could you change the design to "{{docker_image_name}}:{{docker_image_tag}}"?
Contributor
Author
There was a problem hiding this comment.
It won't always have the {{docker_image_name}}:{{docker_image_tag}} schema, for example, the user can install using a image digest and then this is what it will get in in that variable.
How about changing the name to docker_image_reference?
This could mean both the both the image name with the tag and also image digest
Collaborator
There was a problem hiding this comment.
docker_image_reference looks good name to me.
Contributor
Author
There was a problem hiding this comment.
@qiluo-msft
Since the sonic-utilities PR was already merged, we needed another PR to change the name:
sonic-net/sonic-utilities#3998
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Jul 21, 2025
Collaborator
|
Cherry-pick PR to 202505: #23421 |
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jul 31, 2025
What I did Rename the variable tag to docker_image_reference since it can also hold image digest. How I did it Change the variable name to match the name agreed on sonic-net/sonic-buildimage#22911 How to verify it Install App Extension
mssonicbld
added a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Aug 4, 2025
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git commit -s` **
If this is a bug fix, make sure your description includes "closes #xxxx",
"fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related
issue when the PR is merged.
If you are adding/modifying/removing any command or utility script, please also
make sure to add/modify/remove any unit tests from the tests
directory as appropriate.
If you are modifying or removing an existing 'show', 'config' or 'sonic-clear'
subcommand, or you are adding a new subcommand, please make sure you also
update the Command Line Reference Guide (doc/Command-Reference.md) to reflect
your changes.
Please provide the following information:
-->
#### What I did
Rename the variable tag to docker_image_reference since it can also hold image digest.
#### How I did it
Change the variable name to match the name agreed on sonic-net/sonic-buildimage#22911
#### How to verify it
Install App Extension
#### Previous command output (if the output of a command-line utility has changed)
#### New command output (if the output of a command-line utility has changed)
mssonicbld
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Aug 4, 2025
<!-- Please make sure you've read and understood our contributing guidelines: https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md failure_prs.log skip_prs.log Make sure all your commits include a signature generated with `git commit -s` ** If this is a bug fix, make sure your description includes "closes #xxxx", "fixes #xxxx" or "resolves #xxxx" so that GitHub automatically closes the related issue when the PR is merged. If you are adding/modifying/removing any command or utility script, please also make sure to add/modify/remove any unit tests from the tests directory as appropriate. If you are modifying or removing an existing 'show', 'config' or 'sonic-clear' subcommand, or you are adding a new subcommand, please make sure you also update the Command Line Reference Guide (doc/Command-Reference.md) to reflect your changes. Please provide the following information: --> #### What I did Rename the variable tag to docker_image_reference since it can also hold image digest. #### How I did it Change the variable name to match the name agreed on sonic-net/sonic-buildimage#22911 #### How to verify it Install App Extension #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
YairRaviv
pushed a commit
to YairRaviv/sonic-utilities
that referenced
this pull request
Jan 12, 2026
What I did Rename the variable tag to docker_image_reference since it can also hold image digest. How I did it Change the variable name to match the name agreed on sonic-net/sonic-buildimage#22911 How to verify it Install App Extension
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is done in order to be able to start using tag which will provide a user-friendly identifier when running docker ps.
Needed PR: sonic-net/sonic-utilities#3917
Why I did it
To fix #22124 while keeping the wanted ability to get real image while using docker ps
Work item tracking
How I did it
docker_image_ctl.j2to add support for usingdocker_image_tagwhen starting containersdocker_image_tagis defined and not nonelatesttagHow to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)