Skip to content

[PDDF] Fix expected i2c path#22760

Merged
Praveen-Brcm merged 1 commit intosonic-net:masterfrom
nate-nexthop:i2c-fix
Jul 29, 2025
Merged

[PDDF] Fix expected i2c path#22760
Praveen-Brcm merged 1 commit intosonic-net:masterfrom
nate-nexthop:i2c-fix

Conversation

@lotus-nexthop
Copy link
Copy Markdown
Contributor

@lotus-nexthop lotus-nexthop commented May 29, 2025

Why I did it

Fixes #22824
The i2c device address is padded to 4 digits in sysfs:

root@sonic:/sys/bus/i2c/devices# ls
10-0048  26-0050  31-0050  36-0050  41-0050  46-0050  51-0050  56-0050  61-0050  66-0050  71-0050  76-0050  81-0050  86-0050  i2c-23  i2c-32  i2c-41  i2c-50  i2c-6   i2c-69  i2c-78  i2c-9
10-0050  27-0008  32-0008  37-0008  42-0008  47-0008  52-0008  57-0008  62-0008  67-0008  72-0008  77-0008  82-0008  i2c-0    i2c-24  i2c-33  i2c-42  i2c-51  i2c-60  i2c-7   i2c-79
19-0008  27-0050  32-0050  37-0050  42-0050  47-0050  52-0050  57-0050  62-0050  67-0050  72-0050  77-0050  82-0050  i2c-1    i2c-25  i2c-34  i2c-43  i2c-52  i2c-61  i2c-70  i2c-8
23-0008  28-0008  33-0008  38-0008  43-0008  48-0008  53-0008  58-0008  63-0008  68-0008  73-0008  78-0008  83-0008  i2c-10   i2c-26  i2c-35  i2c-44  i2c-53  i2c-62  i2c-71  i2c-80
23-0050  28-0050  33-0050  38-0050  43-0050  48-0050  53-0050  58-0050  63-0050  68-0050  73-0050  78-0050  83-0050  i2c-11   i2c-27  i2c-36  i2c-45  i2c-54  i2c-63  i2c-72  i2c-81
24-0008  29-0008  34-0008  39-0008  44-0008  49-0008  54-0008  59-0008  64-0008  69-0008  74-0008  79-0008  84-0008  i2c-19   i2c-28  i2c-37  i2c-46  i2c-55  i2c-64  i2c-73  i2c-82
24-0050  29-0050  34-0050  39-0050  44-0050  49-0050  54-0050  59-0050  64-0050  69-0050  74-0050  79-0050  84-0050  i2c-2    i2c-29  i2c-38  i2c-47  i2c-56  i2c-65  i2c-74  i2c-83
25-0008  30-0008  35-0008  40-0008  45-0008  50-0008  55-0008  60-0008  65-0008  70-0008  75-0008  80-0008  85-0008  i2c-20   i2c-3   i2c-39  i2c-48  i2c-57  i2c-66  i2c-75  i2c-84
25-0050  30-0050  35-0050  40-0050  45-0050  50-0050  55-0050  60-0050  65-0050  70-0050  75-0050  80-0050  85-0050  i2c-21   i2c-30  i2c-4   i2c-49  i2c-58  i2c-67  i2c-76  i2c-85
26-0008  31-0008  36-0008  41-0008  46-0008  51-0008  56-0008  61-0008  66-0008  71-0008  76-0008  81-0008  86-0008  i2c-22   i2c-31  i2c-40  i2c-5   i2c-59  i2c-68  i2c-77  i2c-86

Multiple functions in pddfparse.py and pddfapi.py will read the wrong sysfs path due to incorrect padding for devices with 1-digit addresses. For example, expecting the device to be 19-008 instead of 19-0008.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Fix the zero padding for every i2c device sysfs path

How to verify it

Tested on NH-4010 sonic platform API object.

Which release branch to backport (provide reason below if selected)

  • 202205
  • 202211
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Copy Markdown
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@lotus-nexthop lotus-nexthop marked this pull request as ready for review June 2, 2025 22:37
@lotus-nexthop lotus-nexthop requested a review from lguohan as a code owner June 2, 2025 22:37
@michaelc-nexthop
Copy link
Copy Markdown
Contributor

LGTM!

@adyeung
Copy link
Copy Markdown
Collaborator

adyeung commented Jun 4, 2025

@FuzailBrcm @Praveen-Brcm pls help review

Copy link
Copy Markdown
Contributor

@geans-pin geans-pin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@michaelc-nexthop
Copy link
Copy Markdown
Contributor

@Praveen-Brcm can you please help review and merge?

@Praveen-Brcm Praveen-Brcm merged commit b46526e into sonic-net:master Jul 29, 2025
12 checks passed
ccroy-arista pushed a commit to ccroy-arista/sonic-buildimage that referenced this pull request Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Fix i2c path padding in PDDF

7 participants