[PDDF] Fix expected i2c path#22760
Merged
Praveen-Brcm merged 1 commit intosonic-net:masterfrom Jul 29, 2025
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
Contributor
|
LGTM! |
Collaborator
|
@FuzailBrcm @Praveen-Brcm pls help review |
geans-pin
approved these changes
Jul 10, 2025
FuzailBrcm
approved these changes
Jul 17, 2025
Contributor
|
@Praveen-Brcm can you please help review and merge? |
Praveen-Brcm
approved these changes
Jul 29, 2025
ccroy-arista
pushed a commit
to ccroy-arista/sonic-buildimage
that referenced
this pull request
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixes #22824
The i2c device address is padded to 4 digits in sysfs:
Multiple functions in pddfparse.py and pddfapi.py will read the wrong sysfs path due to incorrect padding for devices with 1-digit addresses. For example, expecting the device to be 19-008 instead of 19-0008.
Work item tracking
How I did it
Fix the zero padding for every i2c device sysfs path
How to verify it
Tested on NH-4010 sonic platform API object.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)