[Mellanox] platform: Enable cache on init#22651
Closed
jianyuewu wants to merge 1 commit intosonic-net:masterfrom
Closed
[Mellanox] platform: Enable cache on init#22651jianyuewu wants to merge 1 commit intosonic-net:masterfrom
jianyuewu wants to merge 1 commit intosonic-net:masterfrom
Conversation
Set cache enabled flag. Signed-off-by: Jianyue Wu <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
May 20, 2025
keboliu
added
Request for msft-202412 Branch
and removed
Cherry Pick Conflict_202411
labels
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jianyuewu
force-pushed
the
enable_cmis_cache
branch
from
4550799 to
8846757
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw run |
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw ms_conflict |
r12f
pushed a commit
to Azure/sonic-buildimage-msft
that referenced
this pull request
May 22, 2025
202412 Cherry-pick PR for sonic-net/sonic-buildimage#22651 Signed-off-by: Jianyue Wu <[email protected]>
r12f
added
Approved for msft-202412 Branch
Included in msft-202412 Branch
and removed
Cherry Pick Conflict_msft-202412
labels
Collaborator
|
@prgeor would you please review? |
Contributor
Author
|
Cache can be enabled by all vendors, so no need this PR. |
Contributor
|
Hi @jianyuewu @keboliu , just removed request for 202505 label since it's closed, please add it back if reopen and needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on: sonic-net/sonic-platform-common#562
Set cache enabled flag.
Why I did it
Centralize the XCVR cache enablement logic in the Mellanox platform API so that CMIS cache is configured automatically at Platform initialization for Mellanox platform.
How I did it
In Platform.init, call CmisApi.set_cache_enabled(True) to set as cache_enabled in cmis.
How to verify it
Build and deploy the updated platform daemon package.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master.637-eafe0ccb9_Internal