[build] Fix kdump build failure (Fixes 5097 17023)#22553
[build] Fix kdump build failure (Fixes 5097 17023)#22553lguohan merged 1 commit intosonic-net:masterfrom
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw ms_conflict |
|
@lguohan could you please take a look? The change is very small |
|
@saiarcot895 @qiluo-msft can you please review? The change is only 17 LOC and the PR has been pending for a few weeks now |
|
Can you modify the description to add |
saiarcot895
left a comment
saiarcot895
left a comment
There was a problem hiding this comment.
Approved pending description change.
The workaround here will be good enough for SONiC's use cases.
Thanks. Just updated description as requested |
|
@lguohan @saiarcot895 has approved. It looks like your approval is needed for merge. Can you please approve |
|
Please check kvmtest-t0-sonic failure. |
@qiluo-msft Looks like Azure Pipelines cleared the logs from that run as they're over two weeks old, so I can't see any details. Also, is this test stable in baseline? I see it failing on some recent commits to master (for example: c19ece7) Lastly, what does this test check? This change should only impact build. |
|
Thanks @lguohan. Can this fix also be double committed into 202405, 202411 and 202505 please? |
yejianquan
added
Approved for 202505 Branch
and removed
Approved for 202505 Branch
labels
|
Cherry-pick PR to 202505: #22843 |
|
Cherry-pick PR to 202505: #22894 |
mssonicbld
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
|
@kperumalbfn can you help get this approved/committed to 202405 as well? |
Gentle reminder |
|
@yejianquan can you please help get this commited to 202405? It's been pending for two weeks now |
Hi @jusherma 202405 release manager is @bingwang-ms |
@bingwang-ms Can you please help get this committed to 202405? This is a small build fix and already merged to master |
liushilongbuaa
added
Approved for 202411 Branch
and removed
Approved for 202411 Branch
labels
|
Cherry-pick PR to 202411: #23035 |
Fix sonic-net#5097, Fix sonic-net#17023 Why I did it The build fails if kdump is enabled on the build host, even though the relevant build step is performed in a dockerized chroot. + sudo LANG=C chroot ./fsroot-cisco-8000 kdump-config symlinks 5.10.0-23-2-amd64 Cannot change symbolic links when kdump is loaded ... failed! How I did it kdump installation checks if kdump is already running and aborts if so. This is good in most cases, but it's not relevant when installing into a chroot inside a docker container. This adds a basic patch to disable this check during build. Note that the kdump status of the build host is imported into the docker build container via the sysfs file system: $ ls -id /sys/kernel/kexec_crash_loaded && cat /sys/kernel/kexec_crash_loaded 7824 /sys/kernel/kexec_crash_loaded 0 $ docker run --rm debian bash -c "ls -id /sys/kernel/kexec_crash_loaded && cat /sys/kernel/kexec_crash_loaded" 7824 /sys/kernel/kexec_crash_loaded 0 The inodes and file content are identical inside and outside of the container. How to verify it Enable kdump on the build host Confirm baseline build fails with the "Cannot change symbolic links when kdump is loaded" error Apply this change and build succeeds
@bingwang-ms Gentle reminder |
|
@abdosi please help check if we'll back port this to msft-202405 or not needed |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
|
@bingwang-ms @abdosi This is now double committed to 202505 and 202411. Can you please help double commit this build fix to 202405? |
|
Cherry-pick PR to 202405: #23648 |
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
11 participants
Why I did it
The build fails if kdump is enabled on the build host, even though the relevant build step is performed in a dockerized chroot.
Fixes #5097, Fixes #17023
Work item tracking
How I did it
kdump installation checks if kdump is already running and aborts if so. This is good in most cases, but it's not relevant when installing into a chroot inside a docker container. This adds a basic patch to disable this check during build.
Note that the kdump status of the build host is imported into the docker build container via the sysfs file system:
The inodes and file content are identical inside and outside of the container.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master (2975205)
Description for the changelog
[build] fix build failure on kdump-enabled hosts
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)