Skip to content

[TACACS] Fix TACACS config revert to old config when device reboot issue. #22342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qiluo-msft merged 2 commits into from
Apr 30, 2025
Merged

[TACACS] Fix TACACS config revert to old config when device reboot issue. #22342

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fe96497
Update config-setup
liuh-80 Apr 16, 2025
5407540
Fix tacacs config file renaming issue
liuh-80 Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions files/image_config/config-setup/config-setup
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,9 @@ apply_tacacs()
sonic-cfggen -j /etc/sonic/old_config/${TACACS_JSON_BACKUP} --write-to-db
echo "Applied tacacs json to restore tacacs credentials"
config save -y

# Change tacacs config file name, so tacacs config will not be revert when device reboot.
Copy link
Copy Markdown
Collaborator

@qiluo-msft qiluo-msft Apr 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change tacacs config file name, so tacacs config will not be revert when device reboot

Should we just remove tacacs-config.service completely and simplified tacacs just as simple as part of the config_db.json? #Closed

Copy link
Copy Markdown
Contributor Author

@liuh-80 liuh-80 Apr 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Complete remove the service is danger, because remove this service may cause SONiC missing TACACS config.
The OS upgrade scenario does not cover by sonic-mgmt test.

mv /etc/sonic/old_config/${TACACS_JSON_BACKUP} /etc/sonic/old_config/${TACACS_JSON_BACKUP}_backup
else
echo "Missing tacacs json to restore tacacs credentials"
fi
Expand Down
Loading