Skip to content

[YANG] DHCPv4 Relay Yang Model#22338

Merged
yxieca merged 7 commits intosonic-net:masterfrom
ashutosh-agrawal:dhcp4-yang-upstream
Sep 5, 2025
Merged

[YANG] DHCPv4 Relay Yang Model#22338
yxieca merged 7 commits intosonic-net:masterfrom
ashutosh-agrawal:dhcp4-yang-upstream

Conversation

@ashutosh-agrawal
Copy link
Member

@ashutosh-agrawal ashutosh-agrawal commented Apr 16, 2025

Why I did it

Yang model for new DHCPv4 Relay design. See following PR for details:

sonic-net/SONiC#1938

Work item tracking
  • Microsoft ADO (number only):

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

New Yang Model for DHCPv4 Relay

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@ashutosh-agrawal ashutosh-agrawal marked this pull request as ready for review April 16, 2025 00:59
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

AnantKishorSharma added a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request May 2, 2025
AnantKishorSharma added a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request May 2, 2025
AnantKishorSharma added a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request May 2, 2025
cshivashgit pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Jul 7, 2025
cshivashgit pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Jul 7, 2025
cshivashgit pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Jul 7, 2025
@yaqiangz yaqiangz self-requested a review August 19, 2025 13:52
@yaqiangz
Copy link
Contributor

Hi @ganglyu could you please help to review this PR?

@yaqiangz
Copy link
Contributor

@ashutosh-agrawal And for the flag configuration to enable/disable new dhcp-relay, I think it's better to place it in DEVICE_METADATA["localhost"], please let me know if you have other insights

Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ashutosh-agrawal
Copy link
Member Author

@ganglyu Appreciate your review of this PR. The corresponding HLD is already merged.

sonic-net/SONiC#1938

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ashutosh-agrawal
Copy link
Member Author

@qiluo-msft Please help review this PR. The feature HLD is already merged.

@yaqiangz
Copy link
Contributor

yaqiangz commented Sep 1, 2025

@ashutosh-agrawal And for the flag configuration to enable/disable new dhcp-relay, I think it's better to place it in DEVICE_METADATA["localhost"], please let me know if you have other insights

@ashutosh-agrawal Any insights about it?

@ashutosh-agrawal
Copy link
Member Author

@ashutosh-agrawal And for the flag configuration to enable/disable new dhcp-relay, I think it's better to place it in DEVICE_METADATA["localhost"], please let me know if you have other insights

@ashutosh-agrawal Any insights about it?

@yaqiangz Yes, we can move the flag to DEVICE_METADATA["localhost"] table. That change would be done in the following PR.

#22486

We would work on the change in the PR above. Meanwhile, appreciate if you can help move this PR forward.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ashutosh-agrawal ashutosh-agrawal changed the title DHCPv4 Relay Yang Model [YANG] DHCPv4 Relay Yang Model Sep 2, 2025
@yaqiangz
Copy link
Contributor

yaqiangz commented Sep 5, 2025

Hi @yxieca could you please help to merge this PR?

@yxieca yxieca merged commit 1d69fbc into sonic-net:master Sep 5, 2025
20 checks passed
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
Signed-off-by: Anant Kishor Sharma <ananshar@cisco.com>
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
Signed-off-by: Anant Kishor Sharma <ananshar@cisco.com>
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
Signed-off-by: Anant Kishor Sharma <ananshar@cisco.com>
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
Signed-off-by: Anant Kishor Sharma <ananshar@cisco.com>
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
Signed-off-by: Anant Kishor Sharma <ananshar@cisco.com>
ashutosh-agrawal pushed a commit to AnantKishorSharma/sonic-buildimage that referenced this pull request Nov 30, 2025
Signed-off-by: Anant Kishor Sharma <ananshar@cisco.com>
FengPan-Frank pushed a commit to FengPan-Frank/sonic-buildimage that referenced this pull request Dec 4, 2025
Why I did it
Yang model for new DHCPv4 Relay design. See following PR for details:

Signed-off-by: Ashutosh Agrawal <ashu@cisco.com>
Signed-off-by: Feng Pan <fenpan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants