Yang model changes for additional SpineRouter roles - #22285
Merged
qiluo-msft merged 6 commits intoApr 17, 2025
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tjchadaga
changed the title
11 tasks
…into disagg_chassis_roles_yang
Signed-off-by: Tejaswini Chadaga <tchadaga@microsoft.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
…into disagg_chassis_roles_yang
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
arlakshm
approved these changes
Apr 16, 2025
Contributor
|
@yxieca, @bingwang-ms for viz.. |
ganglyu
approved these changes
Apr 17, 2025
wen587
approved these changes
Apr 17, 2025
10 tasks
rlhui
pushed a commit
that referenced
this pull request
May 2, 2025
To support additional SpineRouter roles (UpperSpineRouter, FabricSpineRouter and LowerSpineRouter) for disaggregated chassis introduced in #22285 Main changes include Wherever 'SpineRouter' check was used to run chassis-specific code, change the code to explicitly look for modular chassis linecard (upstreamLC/downstreamLC) Change BGPMON to use Loopback4096 on UpperSpineRouter as well Ensure anchor route configuration are processed on UpperSpineRouter and UpstreamLC of SpineRouter --------- Signed-off-by: Tejaswini Chadaga <tchadaga@microsoft.com>
arlakshm
added a commit
to Azure/sonic-buildimage-msft
that referenced
this pull request
May 6, 2025
<!--
Please make sure you've read and understood our contributing guidelines:
https://github.com/Azure/SONiC/blob/gh-pages/CONTRIBUTING.md
** Make sure all your commits include a signature generated with `git
commit -s` **
If this is a bug fix, make sure your description includes "fixes #xxxx",
or
"closes #xxxx" or "resolves #xxxx"
Please provide the following information:
-->
Manual cherry-pick of
sonic-net/sonic-buildimage#22337
#### Why I did it
To support additional SpineRouter roles introduced in
sonic-net/sonic-buildimage#22285
##### Work item tracking
- Microsoft ADO **(number only)**:
#### How I did it
Added additional roles to checks of spinerouter, changed chassis
specific code to look for upstream/downstreamLC
#### How to verify it
Test with switch role set to one of the new SpineRouter roles
<!--
If PR needs to be backported, then the PR must be tested against the
base branch and the earliest backport release branch and provide tested
image version on these two branches. For example, if the PR is requested
for master, 202211 and 202012, then the requester needs to provide test
results on master and 202012.
-->
#### Which release branch to backport (provide reason below if selected)
<!--
- Note we only backport fixes to a release branch, *not* features!
- Please also provide a reason for the backporting below.
- e.g.
- [x] 202006
-->
- [ ] 201811
- [ ] 201911
- [ ] 202006
- [ ] 202012
- [ ] 202106
- [ ] 202111
- [ ] 202205
- [ ] 202211
#### Tested branch (Please provide the tested image version)
<!--
- Please provide tested image version
- e.g.
- [x] 20201231.100
-->
- [ ] <!-- image version 1 -->
- [ ] <!-- image version 2 -->
#### Description for the changelog
<!--
Write a short (one line) summary that describes the changes in this
pull request for inclusion in the changelog:
-->
<!--
Ensure to add label/tag for the feature raised. example - PR#2174 under
sonic-utilities repo. where, Generic Config and Update feature has been
labelled as GCU.
-->
#### Link to config_db schema for YANG module changes
<!--
Provide a link to config_db schema for the table for which YANG model
is defined
Link should point to correct section on
https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md
-->
#### A picture of a cute animal (not mandatory but encouraged)
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
Why I did it Add switch roles to support additional SpineRouter roles How I did it Updated device metadata yang model How to verify it Validate config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang" Build the below python-wheels to validate unit tests and other changes target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
vmittal-msft
pushed a commit
to vmittal-msft/sonic-buildimage
that referenced
this pull request
Oct 20, 2025
…sonic-net#1026) Why I did it Add switch roles to support additional SpineRouter roles Work item tracking Microsoft ADO 32403731: How I did it Updated device metadata yang model How to verify it Validate config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang" Build the below python-wheels to validate unit tests and other changes target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
roger530-ho
pushed a commit
to roger530-ho/sonic-buildimage
that referenced
this pull request
Jun 23, 2026
Why I did it Add switch roles to support additional SpineRouter roles How I did it Updated device metadata yang model How to verify it Validate config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang" Build the below python-wheels to validate unit tests and other changes target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
roger530-ho
pushed a commit
to roger530-ho/sonic-buildimage
that referenced
this pull request
Jun 23, 2026
To support additional SpineRouter roles (UpperSpineRouter, FabricSpineRouter and LowerSpineRouter) for disaggregated chassis introduced in sonic-net#22285 Main changes include Wherever 'SpineRouter' check was used to run chassis-specific code, change the code to explicitly look for modular chassis linecard (upstreamLC/downstreamLC) Change BGPMON to use Loopback4096 on UpperSpineRouter as well Ensure anchor route configuration are processed on UpperSpineRouter and UpstreamLC of SpineRouter --------- Signed-off-by: Tejaswini Chadaga <tchadaga@microsoft.com>
xdqi
pushed a commit
to canonical/sonic-buildimage
that referenced
this pull request
Jul 6, 2026
Why I did it Add switch roles to support additional SpineRouter roles How I did it Updated device metadata yang model How to verify it Validate config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang" Build the below python-wheels to validate unit tests and other changes target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
xdqi
pushed a commit
to canonical/sonic-buildimage
that referenced
this pull request
Jul 6, 2026
To support additional SpineRouter roles (UpperSpineRouter, FabricSpineRouter and LowerSpineRouter) for disaggregated chassis introduced in sonic-net#22285 Main changes include Wherever 'SpineRouter' check was used to run chassis-specific code, change the code to explicitly look for modular chassis linecard (upstreamLC/downstreamLC) Change BGPMON to use Loopback4096 on UpperSpineRouter as well Ensure anchor route configuration are processed on UpperSpineRouter and UpstreamLC of SpineRouter --------- Signed-off-by: Tejaswini Chadaga <tchadaga@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Add switch roles to support additional SpineRouter roles
Work item tracking
How I did it
Updated device metadata yang model
How to verify it
Validate config tree generation using "pyang -Vf tree -p /usr/local/share/yang/modules/ietf ./yang-models/sonic-voq-inband-interface.yang"
Build the below python-wheels to validate unit tests and other changes
target/python-wheels/bullseye/sonic_yang_mgmt-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_yang_models-1.0-py3-none-any.whl
target/python-wheels/bullseye/sonic_config_engine-1.0-py3-none-any.whl
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)