Add patch for gnmi client to support extensive configurations#22273
Merged
qiluo-msft merged 2 commits intosonic-net:masterfrom Apr 11, 2025
Merged
Add patch for gnmi client to support extensive configurations#22273qiluo-msft merged 2 commits intosonic-net:masterfrom
qiluo-msft merged 2 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liuh-80
approved these changes
Apr 9, 2025
qiluo-msft
reviewed
Apr 9, 2025
| + with open(args['arg_file'], 'r') as file: | ||
| + file_content = file.read() | ||
| + simulated_args = shlex.split(file_content) | ||
| + args = vars(argparser.parse_args(simulated_args)) |
Collaborator
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Apr 10, 2025
9 tasks
11 tasks
Collaborator
|
Cherry-pick PR to 202411: #23026 |
Collaborator
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
11 tasks
Collaborator
|
Cherry-pick PR to 202405: #23151 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The command line has a length limitation, which restricts the number of configurations it can support.
Work item tracking
How I did it
To overcome this limitation, introduce a new argument: arg_file. Users can place extensive configurations within the arg_file, enabling the GNMI client to handle a larger and more complex set of configurations.
How to verify it
Run gnmi end to end test
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)