Add delete template for dynamic BGP peers#22229
Merged
StormLiangMS merged 4 commits intosonic-net:masterfrom May 10, 2025
Merged
Add delete template for dynamic BGP peers#22229StormLiangMS merged 4 commits intosonic-net:masterfrom
StormLiangMS merged 4 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NavdhaJindal
changed the title
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@NavdhaJindal , can you please fill in the description with all details and behaviour change with and without this change? |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NavdhaJindal
changed the title
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
anish-n
approved these changes
Apr 29, 2025
prsunny
previously approved these changes
Apr 29, 2025
sudarshankumar4893
approved these changes
Apr 29, 2025
Contributor
|
hi @NavdhaJindal could you come up test plan and add test case in sonic-mgmt repo?
|
NavdhaJindal
force-pushed
the
dev/navdhajindal/delete-template
branch
from
bed9fc4 to
1d99bb6
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NavdhaJindal
force-pushed
the
dev/navdhajindal/delete-template
branch
from
1d99bb6 to
f5fb6ca
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azpw ms_conflict |
NavdhaJindal
force-pushed
the
dev/navdhajindal/delete-template
branch
from
f5fb6ca to
0dec9f0
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
NavdhaJindal
force-pushed
the
dev/navdhajindal/delete-template
branch
from
0dec9f0 to
7aa3729
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This change is to support enhanced CRUD operations on dynamic bgp peers using a standard template-based mechanism.
Here is the High level design document explaining this feature:
sonic-net/SONiC#1963
Work item tracking
How I did it
Upon a delete peer ocurring, we render the delete template(instead of executing the current behavior of
no neighbor {{ neighbor addr}}), on the other hand if a delete template is not defined then the default behavior ofno neighbor {{ neighbor addr}}applies as usual, thereby making this change backward compatible.How to verify it
Create a dynamic peer like so in config_db.json:
"BGP_NEIGHBOR": {
"10.0.0.62": {
"admin_status": "up",
"asn": "65100",
"holdtime": "10",
"keepalive": "3",
"local_addr": "10.0.0.63",
"name": "vlab-01",
"nhopself": "0",
"rrclient": "0"
}
}
Once the peer is up, delete the neighbor (eg. config bgp neighbor remove ). Verify that the neighbor is deleted.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)