[orchagent.sh] mask SIGHUP before starting orchagent#22207
Merged
yxieca merged 1 commit intosonic-net:masterfrom Apr 30, 2025
Merged
[orchagent.sh] mask SIGHUP before starting orchagent#22207yxieca merged 1 commit intosonic-net:masterfrom
yxieca merged 1 commit intosonic-net:masterfrom
Conversation
logrotate uses SIGHUP to let orchagent rotate SAI Redis recording. If SIGHUP is sent by logrotate before orchagent register its handler the default action takes place - termination. If we mask the signal in the start script orchagent inherits masked signals and will ignore SIGHUP until signal handler is registered. This is a rare race condition observed during 1000 warm-reboot testing. Signed-off-by: Stepan Blyschak <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
13 tasks
volodymyrsamotiy
approved these changes
Apr 2, 2025
This was referenced Apr 2, 2025
kperumalbfn
approved these changes
Apr 2, 2025
Contributor
|
@prsunny, @stepanblyschak Will the signal |
Collaborator
Author
|
@bingwang-ms If SIGHUP is sent to orchagent before handlers are registered the orchagent will terminate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
FIXES #21962
logrotate uses SIGHUP to let orchagent reopen SAI Redis recording. If SIGHUP is sent by logrotate before orchagent register its handler the default action takes place - termination. If we mask the signal in the start script orchagent inherits masked signals and will ignore SIGHUP until signal handler is registered.
This is a rare race condition observed during 1000 warm-reboot testing.
Work item tracking
How I did it
Mask SIGHUP
How to verify it
Place sleep inside orchagent before signal handler for SIGHUP is registered. Send SIGHUP as if it would be sent from logrotate script, ensure no orchagent termination.
Which release branch to backport (provide reason below if selected)
Request to backport to all active branches.
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)