Split frr_bmp feature switch for turn on FRR side bmp tunneling via Liquid#22148
Split frr_bmp feature switch for turn on FRR side bmp tunneling via Liquid#22148qiluo-msft merged 5 commits intosonic-net:masterfrom
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| {# set bmp info #} | ||
| {% if (FEATURE is defined) and ('bmp' in FEATURE) and ('state' in FEATURE['bmp']) and (FEATURE['bmp']['state'] == 'enabled') %} | ||
| {# set frr_bmp info #} | ||
| {% if (FEATURE is defined) and ('frr_bmp' in FEATURE) and ('state' in FEATURE['frr_bmp']) and (FEATURE['frr_bmp']['state'] == 'enabled') %} |
There was a problem hiding this comment.
better to make the config backward compatible:
bmp -> bmp (control the bmp functionality inside FRR)
bmp -> bmp_container (control whether to start bpm container) #Closed
There was a problem hiding this comment.
Seems current mgmt test flow will regard any item in FEATURE table as container, and broke in mgmt test refer https://elastictest.org/scheduler/testplan/67ee3c711a569391805d4f44?testcase=test_pretest.py%7C%7C%7Cvms-kvm-t0_497835&type=console
we should need keep bmp as bmp container by default and used in mgmt test, frr_bmp only used for liquid feature switch control. Thus add one more feature switch frr_bmp into here:
- For mgmt test, we don't need any change and "bmp" is used to turn on both FRR and bmp container for testing.
- For FRR only enable option, we can use "frr_bmp" liquid to control it dynamically.
- For FRR + bmp container enable option, we can use liquid "bmp" to control it dynamically.
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 participants
liquid.
Why I did it
Use new feature switch to turn on FRR side bmp tunneling, so that we can control FRR side feature switch in image first, and BMP container side feature will be controlled via kubeSonic rollout.
Work item tracking
How I did it
Create new feature switch for FRR side bmp tunneling
How to verify it
Unit test is covered.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)