Validate docker image before uploading to registry#21916
Merged
wangxin merged 3 commits intosonic-net:masterfrom Mar 14, 2025
Merged
Validate docker image before uploading to registry#21916wangxin merged 3 commits intosonic-net:masterfrom
wangxin merged 3 commits intosonic-net:masterfrom
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yutongzhang-microsoft
force-pushed
the
yutongzhang/validate_image
branch
from
db26cfd to
4ad1944
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
1 similar comment
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
liushilongbuaa
approved these changes
Mar 12, 2025
wangxin
reviewed
Mar 12, 2025
| cd ../ | ||
| docker rm -f sonic-mgmt | ||
|
|
||
| ./setup-container.sh -n sonic-mgmt -d /data -i docker-sonic-mgmt -v |
Contributor
There was a problem hiding this comment.
How about run something inside the docker to verify that the sonic-mgmt container is actually running?
Contributor
Author
There was a problem hiding this comment.
I add docker exec sonic-mgmt bash -c "echo 'Container is running' && ps aux" to verify. If the container is not running, this command will fail.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
approved these changes
Mar 14, 2025
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Before pushing the newly built docker image to the registry, we add a verification step to ensure the image is valid.
Work item tracking
How I did it
Before pushing the newly built Docker image to the registry, we add a verification step to ensure the image is valid.
How to verify it
For ref https://dev.azure.com/mssonic/build/_build/results?buildId=794495&view=results
If the validate step fails, it won't push the image to registry.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)