Skip to content

[build] Fix command docker images missing name and tag issue.#21882

Merged
wangxin merged 2 commits intosonic-net:masterfrom
liushilongbuaa:fixdockertagmissing
Mar 4, 2025
Merged

[build] Fix command docker images missing name and tag issue.#21882
wangxin merged 2 commits intosonic-net:masterfrom
liushilongbuaa:fixdockertagmissing

Conversation

@liushilongbuaa
Copy link
Contributor

@liushilongbuaa liushilongbuaa commented Feb 27, 2025

Why I did it

when onboard sonic-package-management extension.
It missed to add sonic version label on docker images.

Work item tracking
  • Microsoft ADO (number only): 25662623

How I did it

Check build logs. label is added with this PR.

How to verify it

image

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa liushilongbuaa marked this pull request as ready for review February 28, 2025 02:53
Copy link
Collaborator

@gechiang gechiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa liushilongbuaa marked this pull request as draft February 28, 2025 10:12
@liushilongbuaa
Copy link
Contributor Author

Update src/sonic-utilities for test. If it works, I will remove utilities changes.
I will create a PR to update utilities.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liushilongbuaa liushilongbuaa marked this pull request as ready for review March 3, 2025 08:48
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@liushilongbuaa liushilongbuaa changed the title [build] Fix sonic package manager missing sonic version issue. [build] Fix command docker images missing name and tag issue. Mar 3, 2025
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@yaqiangz yaqiangz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liushilongbuaa
Copy link
Contributor Author

/easycla

@wangxin wangxin merged commit 8e48c0d into sonic-net:master Mar 4, 2025
21 checks passed
miatttao pushed a commit to miatttao/sonic-buildimage that referenced this pull request Mar 5, 2025
…net#21882)

Why I did it
when onboard sonic-package-management extension.
It missed to add sonic version label on docker images.

Work item tracking
Microsoft ADO (number only): 25662623

How I did it
Check build logs. label is added with this PR.
DavidZagury added a commit to DavidZagury/sonic-buildimage that referenced this pull request May 7, 2025
stepanblyschak pushed a commit to stepanblyschak/sonic-buildimage that referenced this pull request May 9, 2025
DavidZagury added a commit to DavidZagury/sonic-buildimage that referenced this pull request Jun 16, 2025
stephenxs pushed a commit to stephenxs/sonic-buildimage that referenced this pull request Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants