[Nokia][Device] Add BCM DNX soc properties to set STAN_ALN mode correctly#21864
Merged
rlhui merged 3 commits intosonic-net:masterfrom Apr 8, 2025
Merged
Conversation
Contributor
Author
|
@vmittal-msft @arlakshm @rlhui , Please review it |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
requested changes
Feb 28, 2025
Contributor
vmittal-msft
left a comment
vmittal-msft
left a comment
There was a problem hiding this comment.
@saksarav-nokia we may need to change high/low to 50%/25% of total fabric links as per BRCM recommendation. please update/re-test.
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
vmittal-msft
approved these changes
Mar 4, 2025
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Contributor
|
@vmittal-msft do we need this in 202411, could you pls check it. |
…ctly Signed-off-by: saksarav <[email protected]>
Signed-off-by: saksarav <[email protected]>
Signed-off-by: saksarav <[email protected]>
saksarav-nokia
force-pushed
the
saksarav-nokia-stan_aln_mode
branch
from
255ca81 to
8160f63
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
No. Let me remove tag. |
vmittal-msft
added
Request for 202411 Branch
and removed
Request for 202411 Branch
Cherry Pick Conflict_202411
labels
Contributor
Yes |
Contributor
|
Thanks @vmittal-msft @saksarav-nokia Please create a separate PR for 202411 after merge as we have conflicts. |
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
10 tasks
arlakshm
approved these changes
Apr 4, 2025
arlakshm
added a commit
to Azure/sonic-buildimage-msft
that referenced
this pull request
Apr 21, 2025
…ctly (#966) Why I did it Porting the PR sonic-net/sonic-buildimage#21864 to msft repo. The STAN_ALN mode was set incorrectly in BCM DNX asics and was advised by BCM to set these soc variables to correct it (One FAP with STAN_ALN=1 and other FAPs with STAN_ALN=0). How I did it Added the soc variables in BCM config How to verify it Verified the STAN_ALN mode in all FAPS and also passing traffic without any issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
The STAN_ALN mode was set incorrectly in BCM DNX asics and was advised by BCM to set these soc variables to correct it (One FAP with STAN_ALN=1 and other FAPs with STAN_ALN=0).
Work item tracking
How I did it
Added the soc variables in BCM config
How to verify it
Verified the STAN_ALN mode and also passing traffic without any issues.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)