[201911] Backport: Rename the platform_reboot to the pre_reboot_hook, remove the sysfs power cycle#21687
Closed
jianyuewu wants to merge 1 commit intosonic-net:201911from
Closed
[201911] Backport: Rename the platform_reboot to the pre_reboot_hook, remove the sysfs power cycle#21687jianyuewu wants to merge 1 commit intosonic-net:201911from
jianyuewu wants to merge 1 commit intosonic-net:201911from
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
Back port from master branch. Why I did it Back port graceful reboot instead of the sysfs power cycle to avoid filesystem corruption. How I did it Rename the platform_reboot script to the pre_reboot_hook. Remove the sysfs power cycle function, from now on the Debian reboot (/sbin/reboot) will be executed instead of the sysfs power cycle. How to verify it Start watching logs by using show log -f and journalctl -p debug -f. Execute the reboot command from the switch CLI. Check in logs that all systemd services terminated. Signed-off-by: Jianyue Wu <[email protected]>
jianyuewu
force-pushed
the
201911_reboot_precheck
branch
from
96fb6b9 to
8b1c08b
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines failed to run 1 pipeline(s). |
1 task
keboliu
approved these changes
Feb 13, 2025
Collaborator
|
/AzurePipelines run |
|
Azure Pipelines failed to run 1 pipeline(s). |
|
@bingwang-ms if this is needed for 1911 please merge, if not please let us know and we will close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport commit #18324.
Why I did it
Back port graceful reboot instead of the sysfs power cycle to avoid filesystem corruption.
How I did it
Rename the platform_reboot script to the pre_reboot_hook. Remove the sysfs power cycle function, from now on the Debian reboot (/sbin/reboot) will be executed instead of the sysfs power cycle.
How to verify it
Start watching logs by using show log -f and journalctl -p debug -f Execute the reboot command from the switch CLI
Check in logs that all systemd services terminated
Which release branch to backport (provide reason below if selected)
Because 201911 branch is missing this change.
Tested branch (Please provide the tested image version)
SONiC.201911.209-bea968bb