Revert unix socket for chassis db#21606
Merged
qiluo-msft merged 4 commits intosonic-net:masterfrom Feb 24, 2025
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
@tjchadaga , why this PR is still in draft mode? I think we indeed need this PR. |
BYGX-wcr
approved these changes
Feb 21, 2025
Contributor
BYGX-wcr
left a comment
BYGX-wcr
left a comment
There was a problem hiding this comment.
LGTM. Tested on virtual chassis.
tjchadaga
changed the title
qiluo-msft
reviewed
Feb 21, 2025
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Feb 21, 2025
liuh-80
approved these changes
Feb 24, 2025
Contributor
liuh-80
left a comment
liuh-80
left a comment
There was a problem hiding this comment.
Can we enable T2 test case to prevent similar regression?
miatttao
pushed a commit
to miatttao/sonic-buildimage
that referenced
this pull request
Mar 5, 2025
Why I did it Reverting part of sonic-net#21345, since Chassis DB connection from remote host (linecard) cannot use unix socket How I did it Continue to use TCP socket for chassis DB connection How to verify it Bring up BGP on chassis, which currently fails after change in sonic-net#21345
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Reverting part of #21345, since Chassis DB connection from remote host (linecard) cannot use unix socket
Work item tracking
How I did it
Continue to use TCP socket for chassis DB connection
How to verify it
Bring up BGP on chassis, which currently fails after change in #21345
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)