T2-Route-Conv: Process Crash Optimization#21587
Merged
rlhui merged 4 commits intosonic-net:masterfrom Feb 11, 2025
Merged
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
11 tasks
arlakshm
reviewed
Feb 7, 2025
…nd contains startup-tsa-tsb.service
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
lgtm |
tjchadaga
reviewed
Feb 10, 2025
arista-nwolfe
approved these changes
Feb 10, 2025
Contributor
arista-nwolfe
left a comment
arista-nwolfe
left a comment
There was a problem hiding this comment.
LGTM, just a minor comment.
Collaborator
|
/azp run Azure.sonic-buildimage |
Merged
11 tasks
arlakshm
approved these changes
Feb 11, 2025
Collaborator
|
Cherry-pick PR to msft-202405: Azure/sonic-buildimage-msft#603 |
mssonicbld
added
Included in msft-202405 Branch
and removed
Created PR to msft-202405 Branch
labels
mssonicbld
added a commit
to mssonicbld/sonic-mgmt.msft
that referenced
this pull request
Feb 14, 2025
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> Summary: TSA-TSB service Testcases: Adjust the testcases to adhere to new behavior of config_reload ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202012 - [ ] 202205 - [ ] 202305 - [ ] 202311 - [x] 202405 - [x] 202411 ### Approach #### What is the motivation for this PR? As a fix for the issue sonic-net/sonic-buildimage#21586, TSA-TSB service is invoked upon swss bring up(sonic-net/sonic-buildimage#21587). This affects config_reload behavior, where after config reload the tsa-tsb service will be restarted, and the device will be in TSA state till timer expires. Adjusting the testcase to explicitly execute TSB for the DUT to be ready for next testcase, #### How did you do it? Enhanced the config_reload api to optionally take exec_tsb parameter. For startup-TSA-TSB and reliable TSA-TSB testcases, pass this flag to True to explicitly execute TSB on the device after config reload. #### How did you verify/test it? Ran the tests on t2 #### Any platform specific information? NA #### Supported testbed topology if it's a new test case? NA ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? -->
This was referenced Feb 14, 2025
Merged
11 tasks
Collaborator
|
Cherry-pick PR to msft-202503: Azure/sonic-buildimage-msft#1248 |
mssonicbld
added
Included in msft-202503 Branch
and removed
Created PR to msft-202503 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Fixes issue: #21586
Work item tracking
How I did it
Run TSA-TSB service upon swss/swss0/swss1/.. startup. If the service is already running, reset the TSA-TSB timer.
How to verify it
Ran the T2 process crash sonic-mgmt snappi test to verify the convergence.
Before fix: ~10second
After Fix: <10ms
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
SONiC.20240532.04
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)