Exclude pie ports from qos config#21544
Merged
StormLiangMS merged 1 commit intosonic-net:masterfrom Mar 7, 2025
Merged
Conversation
Signed-off-by: Zhixin Zhu <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
alpeshspatel
approved these changes
Jan 28, 2025
Contributor
|
@kperumalbfn , @liat-grozovik and @stephenxs FYI |
Contributor
|
@noaOrMlnx any reason we removed the PORT_QOS_BYPASS in PR #21427? |
Contributor
|
@bingwang-ms any comments on mlx side? |
Contributor
|
@noaOrMlnx Can you please help review? |
stephenxs
approved these changes
Feb 28, 2025
Contributor
|
hi @zhixzhu could you add more description about this fix? Like why this is needed and how it works? |
Contributor
Author
|
@StormLiangMS I updated the description, thanks. |
kperumalbfn
approved these changes
Mar 6, 2025
StormLiangMS
approved these changes
Mar 7, 2025
Contributor
StormLiangMS
left a comment
StormLiangMS
left a comment
There was a problem hiding this comment.
Thanks @zhixzhu , LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Some code were deleted by mistake in #21427
Add it back.
There are some ports (PIE ports in cisco platform) don't support buffer/qos config, this is to exclude those ports from PORT_ACTIVE to bypass buffer/qos config.
Work item tracking
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)