Remove empty dscp_to_tc_map macro in qos.j2#21515
Merged
qiluo-msft merged 1 commit intosonic-net:masterfrom May 19, 2025
Merged
Remove empty dscp_to_tc_map macro in qos.j2#21515qiluo-msft merged 1 commit intosonic-net:masterfrom
qiluo-msft merged 1 commit intosonic-net:masterfrom
Conversation
Previously we disable the global dscp_to_tc_map table as sai doesn't support it. Now they have supported it and we need it to enable inner dscp map to tc feature, so remove the old dummy marco and update testing case accordingly. Signed-off-by: Yuanzhe, Liu <yualiu@nvidia.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run Azure.sonic-buildimage |
|
Commenter does not have sufficient privileges for PR 21515 in repo sonic-net/sonic-buildimage |
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
keboliu
approved these changes
Feb 13, 2025
stephenxs
approved these changes
Feb 13, 2025
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
@bingwang-ms would you please review? |
Collaborator
|
@bingwang-ms would you please help to merge? |
Contributor
|
@yxieca Can you help merge this PR? Thanks |
Collaborator
|
Hi @yxieca would you please help to merge? |
Collaborator
|
@liat-grozovik @yxieca can you please help to merge? |
Collaborator
|
Cherry-pick PR to 202505: #22714 |
liushilongbuaa
added
Included in 202505 Branch
and removed
Created PR to 202505 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Previously we disable the global dscp_to_tc_map table as sai doesn't support it. Now they have supported it and we need it to enable inner dscp map to tc feature, so remove the old dummy macro and update testing case accordingly.
Work item tracking
How I did it
Remove empty dscp_to_tc_map macro in qos.j2 and update testing case accordingly.
How to verify it
sonic-net/sonic-mgmt#9098 relevant test had been raised
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)