Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
|
||
| PSU_TYPE_OFFSET = 48 | ||
|
|
||
| class Psu(PsuBase): |
There was a problem hiding this comment.
I see that PddfPsu class is not used. Same is the case with all other components. Maybe the generic implementation is not as per the Dell Platform's need. Hope that approach is tested too.
Generally Pddf<> classes gives a generic implementation of various methods. If they need to be overwritten, it can be done by overwriting the method inside psu.py, fan.py etc.
There was a problem hiding this comment.
pddf specific files are placed under platform/broadcom/sonic-platform-modules-dell/s5448f/pddf/sonic_platform/ . they used pddf class
|
@geans-pin @leeprecy |
|
@lguohan can someone help with this? We had a similar PR as this, for a different platform, pass all checks and get merged successfully sometime back: |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lguohan for tracking/viz. |
|
@lguohan could you merge this ? |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lguohan could you merge this ? |
|
@yxieca , can you help with merge? |
zhangyanzhao
requested review from
Prasanth-KV,
Praveen-Brcm,
baxia-lan and
donNewtonIntel
|
Tag repo maintainers to help on the merge @baxia-lan @Praveen-Brcm @Prasanth-KV @donNewtonIntel @kperumalbfn @lguohan @yxieca |
9 participants
Add Dell S5448 support for community sonic.
Added both pddf and non pddf modes
Test_logs
non_pddf_commands.txt
pddf_commands.txt
Following are platform api test results
did not run test_sfp.py as there is no SAI support
Fan and Fantry name related failures are expected
non_pddf_platform_api_logs.zip
pddf_platform_api_logs.zip