flashrom build fix: incorrect tag name#21473
Merged
wangxin merged 1 commit intosonic-net:masterfrom Jan 21, 2025
Merged
Conversation
flashrom recently started failing to build with the below error: ``` Cloning into 'flashrom-0.9.7'... /sonic/src/flashrom/flashrom-0.9.7 /sonic/src/flashrom fatal: 'tags/0.9.7' is not a commit and a branch 'flashrom-src' cannot be created from it ``` Nothing in sonic-buildimage has changed in relation to this so presumably flashrom upstream renamed their tags. This commit just fixes the formatting of the tag name to use the new format. Signed-off-by: Brad House (@bradh352)
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
11 tasks
wangxin
approved these changes
Jan 21, 2025
This was referenced Jan 21, 2025
Collaborator
|
Cherry-pick PR to 202411: |
Collaborator
|
Cherry-pick PR to 202305: |
Collaborator
|
Cherry-pick PR to 202311: |
1 task
Collaborator
|
Cherry-pick PR to 202405: |
VladimirKuk
pushed a commit
to Marvell-switching/sonic-buildimage
that referenced
this pull request
Jan 21, 2025
flashrom recently started failing to build with the below error: ``` Cloning into 'flashrom-0.9.7'... /sonic/src/flashrom/flashrom-0.9.7 /sonic/src/flashrom fatal: 'tags/0.9.7' is not a commit and a branch 'flashrom-src' cannot be created from it ``` Nothing in sonic-buildimage has changed in relation to this so presumably flashrom upstream renamed their tags. This commit just fixes the formatting of the tag name to use the new format. Signed-off-by: Brad House (@bradh352)
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
This was referenced Jan 27, 2025
Collaborator
|
Cherry-pick PR to 202205: #21535 |
Collaborator
|
Cherry-pick PR to 202211: #21536 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
flashrom recently started failing to build with the below error:
Nothing in sonic-buildimage has changed in relation to this so presumably flashrom upstream renamed their tags.
Work item tracking
How I did it
This commit just fixes the formatting of the tag name to use the new format.
How to verify it
Build sonic from scratch with no cached packages.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master as of 20250119
Description for the changelog
flashrom build fix: incorrect tag name
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
Signed-off-by: Brad House (@bradh352)