Add freeRADIUS package to docker-ptf #21307
Conversation
|
|
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@lguohan can you help me with this PR failure - I don't believe its related to my code change |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@saiarcot895 would you be able to help merge this in? |
|
/azp run Azure.sonic-buildimage |
|
Pull request contains merge conflicts. |
|
@saiarcot895 @wangxin @lguohan I could use a bit of help with this one. I noticed an error before stating that merge commits are not allowed (as I was just rebasing to the parent repo), so I reverted that merge commit, and now it seems I have some conflicts. Do you have guidance on the easiest way to resolve the current situation? Can I just rebase again, and then one of you can merge for me? |
|
Not sure what you mean, but merge commits within PRs should be fine; rebases are fine as well. When the PR gets merged, all commits (and diffs) get squashed into a single commit. |
52295bf to
b695290
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Thanks, @saiarcot895. I rebased, and the conflicts are resolved. Would it be possible to get this change merged in at this point? |
|
@lguohan, could we possibly merge this PR? Without this merge, I can't add the RADIUS test to sonic-mgmt sonic-net/sonic-mgmt#16475 |
Why I did it In a subsequent PR in the sonic-mgmt repo, I will add RADIUS tests, and there needs to be a consumable RADIUS server in the infrastructure. How I did it Added the freeradius package the ptf docker j2 file. How to verify it I build the new docker image locally and then ran few succesfull app-topo tasks inside of sonic-mgmt. Also verifed that freeradius is installed.
Adding freeradius package to docker-ptf to help with RADIUS sonic-mgmt testing.
Why I did it
In a subsequent PR in the sonic-mgmt repo, I will add RADIUS tests, and there needs to be a consumable RADIUS server in the infrastructure.
How I did it
Added the
freeradiuspackage the ptf docker j2 file.How to verify it
I build the new docker image locally and then ran few succesfull app-topo tasks inside of sonic-mgmt. Also verifed that freeradius is installed.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Tested against both 202405 sonic-mgmt and tip of master.
Description for the changelog
Adding freeradius to docker-ptf
A picture of a cute animal (not mandatory but encouraged)