Skip to content

Add freeRADIUS package to docker-ptf #21307

Merged
yxieca merged 1 commit intosonic-net:masterfrom
dt-nexthop:dt-nexthop/add-freeradius
Feb 28, 2025
Merged

Add freeRADIUS package to docker-ptf #21307
yxieca merged 1 commit intosonic-net:masterfrom
dt-nexthop:dt-nexthop/add-freeradius

Conversation

@dt-nexthop
Copy link
Contributor

Adding freeradius package to docker-ptf to help with RADIUS sonic-mgmt testing.

Why I did it

In a subsequent PR in the sonic-mgmt repo, I will add RADIUS tests, and there needs to be a consumable RADIUS server in the infrastructure.

How I did it

Added the freeradius package the ptf docker j2 file.

How to verify it

I build the new docker image locally and then ran few succesfull app-topo tasks inside of sonic-mgmt. Also verifed that freeradius is installed.

make target/docker-ptf.gz
docker load < target/docker-ptf.gz
docker start docker-ptf:lastest

Then inside the docker image:

dt@usschq-asser-t002:~/sonic-buildimage/target$ docker exec -it fe bash
root@fe0000e7dfd0:~# freeradius -v
radiusd: FreeRADIUS Version 3.0.17, for host x86_64-pc-linux-gnu, built on Feb 24 2023 at 12:52:21
FreeRADIUS Version 3.0.17
Copyright (C) 1999-2017 The FreeRADIUS server project and contributors
There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A
PARTICULAR PURPOSE
You may redistribute copies of FreeRADIUS under the terms of the
GNU General Public License
For more information about these matters, see the file named COPYRIGHT
root@fe0000e7dfd0:~#

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Tested against both 202405 sonic-mgmt and tip of master.

Description for the changelog

Adding freeradius to docker-ptf

A picture of a cute animal (not mandatory but encouraged)

bmd jgp

@dt-nexthop dt-nexthop requested a review from lguohan as a code owner December 31, 2024 15:15
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 31, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dt-nexthop
Copy link
Contributor Author

@lguohan can you help me with this PR failure - I don't believe its related to my code change

@yxieca
Copy link
Contributor

yxieca commented Feb 5, 2025

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yxieca yxieca requested review from saiarcot895 and wangxin February 5, 2025 16:58
@dt-nexthop
Copy link
Contributor Author

@saiarcot895 would you be able to help merge this in?

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@dt-nexthop
Copy link
Contributor Author

@saiarcot895 @wangxin @lguohan I could use a bit of help with this one. I noticed an error before stating that merge commits are not allowed (as I was just rebasing to the parent repo), so I reverted that merge commit, and now it seems I have some conflicts. Do you have guidance on the easiest way to resolve the current situation? Can I just rebase again, and then one of you can merge for me?

@saiarcot895
Copy link
Contributor

Not sure what you mean, but merge commits within PRs should be fine; rebases are fine as well. When the PR gets merged, all commits (and diffs) get squashed into a single commit.

@dt-nexthop dt-nexthop closed this Feb 10, 2025
@dt-nexthop dt-nexthop force-pushed the dt-nexthop/add-freeradius branch from 52295bf to b695290 Compare February 10, 2025 02:57
@dt-nexthop dt-nexthop reopened this Feb 10, 2025
@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dt-nexthop
Copy link
Contributor Author

Thanks, @saiarcot895. I rebased, and the conflicts are resolved. Would it be possible to get this change merged in at this point?

@dt-nexthop
Copy link
Contributor Author

dt-nexthop commented Feb 18, 2025

@lguohan, could we possibly merge this PR? Without this merge, I can't add the RADIUS test to sonic-mgmt sonic-net/sonic-mgmt#16475

@yxieca yxieca merged commit 88516a6 into sonic-net:master Feb 28, 2025
24 checks passed
miatttao pushed a commit to miatttao/sonic-buildimage that referenced this pull request Mar 5, 2025
Why I did it
In a subsequent PR in the sonic-mgmt repo, I will add RADIUS tests, and there needs to be a consumable RADIUS server in the infrastructure.

How I did it
Added the freeradius package the ptf docker j2 file.

How to verify it
I build the new docker image locally and then ran few succesfull app-topo tasks inside of sonic-mgmt. Also verifed that freeradius is installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants