[minigraph parser] add basic support for MGMT_PORT#2103
Merged
lguohan merged 2 commits intosonic-net:masterfrom Sep 29, 2018
Merged
[minigraph parser] add basic support for MGMT_PORT#2103lguohan merged 2 commits intosonic-net:masterfrom
lguohan merged 2 commits intosonic-net:masterfrom
Conversation
qiluo-msft
reviewed
Sep 29, 2018
src/sonic-config-engine/minigraph.py
Outdated
| results['MGMT_INTERFACE'] = {} | ||
| for key in mgmt_intf: | ||
| alias = key[0] | ||
| name = 'eth' + alias[-1] |
Collaborator
There was a problem hiding this comment.
alias[-1] [](start = 23, length = 9)
It is not safe to assume there is a minigraph mgmt port name ends with '0', considering sonic mgmt port names are like eth0, eth1, ... #Closed
Contributor
Author
There was a problem hiding this comment.
Addressed. #Resolved
qiluo-msft
approved these changes
Sep 29, 2018
lguohan
approved these changes
Sep 29, 2018
lguohan
pushed a commit
that referenced
this pull request
Oct 2, 2018
* [minigraph parser] add basic support for MGMT_PORT * Change method to determine local interface name
liorghub
added a commit
to liorghub/sonic-buildimage
that referenced
this pull request
Mar 23, 2022
Update sonic-utilities submodule to include below commits: 510a9b9 Add date to show version (sonic-net#2086) 61b1396 [sfpshow][recycle_port] sfpshow script needs to skip recycle ports (sonic-net#2109) 4681697 Support command `show ip fib` and `show ipv6 fib` (sonic-net#2100) 2a982a1 Update `config mirror_session` CLI to support heximal gre type value (sonic-net#2095) b25f1e1 [generic-config-updater] Add caclrule validator (sonic-net#2103) 968900c [sonic-package-manager] do not mod_config for whole config db when setting init_cfg (sonic-net#2055) bf55ceb [nvgre] Added auto-generated CLI plugins and test for NVGRE Tunnel feature (sonic-net#1915)
6 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Mar 30, 2022
Update sonic-utilities submodule to include below commits: 510a9b9 Add date to show version (#2086) 61b1396 [sfpshow][recycle_port] sfpshow script needs to skip recycle ports (#2109) 4681697 Support command `show ip fib` and `show ipv6 fib` (#2100) 2a982a1 Update `config mirror_session` CLI to support heximal gre type value (#2095) b25f1e1 [generic-config-updater] Add caclrule validator (#2103) 968900c [sonic-package-manager] do not mod_config for whole config db when setting init_cfg (#2055) bf55ceb [nvgre] Added auto-generated CLI plugins and test for NVGRE Tunnel feature (#1915) 8389c81 [sonic-cli-gen] fix failure "Error: digits_class" when field "digit_class" does not exist in DB (#2054) f71ef64 Fix import statement in mclag.py (#2073)
taras-keryk
pushed a commit
to taras-keryk/sonic-buildimage
that referenced
this pull request
Apr 28, 2022
Add 1 sec sleep time to make sure caclmgrd does update What I did When GCU make change to control plane ACL_RULE, the iptables doen't change immediately. There is a delay because caclmgrd will update in 0.5 sec if no more update being made to config. So I add a caclrule validator to make sure the iptable is updated. How I did it When caclrule is being changed, add a 1sec sleep to make sure caclmgr does update. How to verify it Run sonic-utilities unit test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Create parsing minigraph for MGMT_PORT table according to design in
https://github.com/Azure/SONiC/wiki/SONiC-SMMP-Design-on-Management-Ports
Currently support
aliasandadmin_statusfield.- How to verify it