Skip to content

Install rdb-cli on syncd-dnx#20948

Merged
lguohan merged 1 commit intosonic-net:masterfrom
patrickmacarthur:master-install-rdb-cli-on-syncd-dnx
Dec 4, 2024
Merged

Install rdb-cli on syncd-dnx#20948
lguohan merged 1 commit intosonic-net:masterfrom
patrickmacarthur:master-install-rdb-cli-on-syncd-dnx

Conversation

@patrickmacarthur
Copy link
Copy Markdown
Contributor

This was missed on the original PR and caused show_techsupport sonic-mgmt tests to fail.

Why I did it

PR #19268 replaced redis-rdb-tool with rdb-cli in the Broadcom XGS syncd container. However, it did not do the same for the DNX syncd container, leading to sonic-mgmt failures in show_techsupport tests on DNX platforms.

Work item tracking
  • Microsoft ADO (number only):

How I did it

I applied the same change to the Broadcom DNX syncd container.

How to verify it

Run sonic-mgmt show_techsupport tests on a Broadcom DNX DUT.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305
  • 202405

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

This was missed on the original PR and caused show_techsupport
sonic-mgmt tests to fail.
@lguohan
Copy link
Copy Markdown
Collaborator

lguohan commented Dec 2, 2024

/azpw ms_conflict

@rlhui rlhui requested a review from judyjoseph December 4, 2024 18:49
Copy link
Copy Markdown
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@judyjoseph
Copy link
Copy Markdown
Contributor

@rlhui @lguohan could you pls help merge - thx

@lguohan lguohan merged commit 8266922 into sonic-net:master Dec 4, 2024
mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Dec 4, 2024
This was missed on the original PR and caused show_techsupport sonic-mgmt tests to fail.

Why I did it
PR sonic-net#19268 replaced redis-rdb-tool with rdb-cli in the Broadcom XGS syncd container. However, it did not do the same for the DNX syncd container, leading to sonic-mgmt failures in show_techsupport tests on DNX platforms.

How I did it
I applied the same change to the Broadcom DNX syncd container.

How to verify it
Run sonic-mgmt show_techsupport tests on a Broadcom DNX DUT.
@mssonicbld
Copy link
Copy Markdown
Collaborator

Cherry-pick PR to 202405: #21033

mssonicbld pushed a commit that referenced this pull request Dec 5, 2024
This was missed on the original PR and caused show_techsupport sonic-mgmt tests to fail.

Why I did it
PR #19268 replaced redis-rdb-tool with rdb-cli in the Broadcom XGS syncd container. However, it did not do the same for the DNX syncd container, leading to sonic-mgmt failures in show_techsupport tests on DNX platforms.

How I did it
I applied the same change to the Broadcom DNX syncd container.

How to verify it
Run sonic-mgmt show_techsupport tests on a Broadcom DNX DUT.
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
This was missed on the original PR and caused show_techsupport sonic-mgmt tests to fail.

Why I did it
PR sonic-net#19268 replaced redis-rdb-tool with rdb-cli in the Broadcom XGS syncd container. However, it did not do the same for the DNX syncd container, leading to sonic-mgmt failures in show_techsupport tests on DNX platforms.

How I did it
I applied the same change to the Broadcom DNX syncd container.

How to verify it
Run sonic-mgmt show_techsupport tests on a Broadcom DNX DUT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants