Skip to content

Add bmp dynamic feature switch in frr side config.#20895

Merged
StormLiangMS merged 3 commits intosonic-net:masterfrom
FengPan-Frank:frr_bmp_config
Nov 26, 2024
Merged

Add bmp dynamic feature switch in frr side config.#20895
StormLiangMS merged 3 commits intosonic-net:masterfrom
FengPan-Frank:frr_bmp_config

Conversation

@FengPan-Frank
Copy link
Contributor

@FengPan-Frank FengPan-Frank commented Nov 22, 2024

Why I did it

Add bmp dynamic feature switch in frr side config, later will update liquid template to control bmp feature based on version.

Work item tracking
  • Microsoft ADO (number only):27588893

How I did it

Update bgpd.conf and supervisord.conf template to monitor the feature switch, and turn on corresponding section. Later once we want to turn on bmp feature, we will assign specific version on NDM liquid template, and on the rollout-ed host it will require a new config reload to take effect.

How to verify it

Added unit test cases.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@FengPan-Frank
Copy link
Contributor Author

Hi @StormLiangMS , we have new feature "bmp" which would like to be enabled in runtime later per NDM liquid config. The feature requires frr side config + cmd change, could you help on review if there's any concern? Thanks

@FengPan-Frank
Copy link
Contributor Author

/azpw ms_conflict

@StormLiangMS
Copy link
Contributor

StormLiangMS commented Nov 26, 2024

hi @FengPan-Frank do we have test case to cover this in nightly? I would be curious about the memory and cpu utilization of this feature.

@FengPan-Frank
Copy link
Contributor Author

FengPan-Frank commented Nov 26, 2024

hi @FengPan-Frank do we have test case to cover this in nightly? I would be curious about the memory and cpu utilization of this feature.

@StormLiangMS I'm working on nightly test cases for this feature continually, for this flag we want to create placeholder on image first which will be controlled by Sonic_FEATURE_Template.liquid dynamically like https://msazure.visualstudio.com/One/_git/Networking-Metadata?path=/src/data/Network/DeviceConfigTemplates/Sonic_BGP_BBR_Template.liquid&version=GBmaster, it will not be enabled unless nightly is in good shape later.

@StormLiangMS StormLiangMS merged commit 8455f9b into sonic-net:master Nov 26, 2024
VladimirKuk pushed a commit to Marvell-switching/sonic-buildimage that referenced this pull request Jan 21, 2025
Why I did it
Add bmp dynamic feature switch in frr side config, later will update liquid template to control bmp feature based on version.

Work item tracking
Microsoft ADO (number only):27588893
How I did it
Update bgpd.conf and supervisord.conf template to monitor the feature switch, and turn on corresponding section. Later once we want to turn on bmp feature, we will assign specific version on NDM liquid template, and on the rollout-ed host it will require a new config reload to take effect.

How to verify it
Added unit test cases.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BMP Bgp Monitor Container

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants