Add bmp dynamic feature switch in frr side config.#20895
Add bmp dynamic feature switch in frr side config.#20895StormLiangMS merged 3 commits intosonic-net:masterfrom
Conversation
c0ab71a to
653788d
Compare
653788d to
5239344
Compare
|
Hi @StormLiangMS , we have new feature "bmp" which would like to be enabled in runtime later per NDM liquid config. The feature requires frr side config + cmd change, could you help on review if there's any concern? Thanks |
|
/azpw ms_conflict |
|
hi @FengPan-Frank do we have test case to cover this in nightly? I would be curious about the memory and cpu utilization of this feature. |
@StormLiangMS I'm working on nightly test cases for this feature continually, for this flag we want to create placeholder on image first which will be controlled by Sonic_FEATURE_Template.liquid dynamically like https://msazure.visualstudio.com/One/_git/Networking-Metadata?path=/src/data/Network/DeviceConfigTemplates/Sonic_BGP_BBR_Template.liquid&version=GBmaster, it will not be enabled unless nightly is in good shape later. |
Why I did it Add bmp dynamic feature switch in frr side config, later will update liquid template to control bmp feature based on version. Work item tracking Microsoft ADO (number only):27588893 How I did it Update bgpd.conf and supervisord.conf template to monitor the feature switch, and turn on corresponding section. Later once we want to turn on bmp feature, we will assign specific version on NDM liquid template, and on the rollout-ed host it will require a new config reload to take effect. How to verify it Added unit test cases.
Why I did it
Add bmp dynamic feature switch in frr side config, later will update liquid template to control bmp feature based on version.
Work item tracking
How I did it
Update bgpd.conf and supervisord.conf template to monitor the feature switch, and turn on corresponding section. Later once we want to turn on bmp feature, we will assign specific version on NDM liquid template, and on the rollout-ed host it will require a new config reload to take effect.
How to verify it
Added unit test cases.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)