[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json by mlok-nokia · Pull Request #20826 · sonic-net/sonic-buildimage

mlok-nokia · 2024-11-15T22:43:50Z

Why I did it

For any platform which supports the asic_sensors pulling, it requires the configuration files (config_db#.json) contain the following configuration to trigger the system to poll the ASIC sensors temperature. Fixes https://github.com/Nokia-ION/ndk/issues/48
Adding Yang model support to fixes #20633

Work item tracking

Microsoft ADO (number only):

How I did it

Add new module src/sonic-config-engine/asic_sensors_config.py with function get_asic_sensors_config(). This function checks if device data platform.json contains the following configuration, it will generate the asic_sensors pulling configuration.

$ cat platform.json
{
...
...
...
   "asic_sensors": {
        "poll_interval": "10",
        "poll_admin_status": "enable"
    }
}

Modify the script sonic-cfggen platform option "-H" to call the function get_asic_sensor_config() to generate the asic_sensors pulling configuration.
Added new UT test_asic_sensors_config() to test_cfggen.py to test related the implementation.

Notice: For all platforms which support the asic_sensors polling requires to add the following definition to the device data platform.json file

$ cat platform.json
{
...
...
...
   "asic_sensors": {
        "poll_interval": "10",
        "poll_admin_status": "enable"
    }
}

Also add Yang Model support the ASIC_SENSORS configuration. INcluding YangModel UT.

How to verify it

Running the new image on the platform which supports the ASIC_SENSORS
Execute the CLI command "sonic-cfggen -H --print-data", the following code will be generated

{
   "ASIC_SENSORS": {
        "ASIC_SENSORS_POLLER_INTERVAL": {
            "interval": "10"
        },
        "ASIC_SENSORS_POLLER_STATUS": {
            "admin_status": "enable"
        }
    }
}

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

mlok-nokia · 2024-11-18T21:22:13Z

@judyjoseph Please review this asic-sensors PR. Thanks

mlok-nokia · 2024-11-22T16:57:34Z

@arlakshm This Includes the Yang Model for ASIC_SENSORS configuration. Please review it

src/sonic-yang-models/yang-models/sonic-asic-sensors.yang

judyjoseph · 2024-11-22T17:23:25Z

Minor comments LGTM

judyjoseph · 2024-11-25T07:31:16Z

/azp run

azure-pipelines · 2024-11-25T07:31:31Z

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm · 2024-11-27T22:54:15Z

/Azp run Azure.sonic-buildimage

azure-pipelines · 2024-11-27T22:54:27Z

Azure Pipelines successfully started running 1 pipeline(s).

arlakshm · 2024-11-27T22:55:44Z

@mlok-nokia, can you divide this PR in two, one for the config_db related change and one for the platform related change

mlok-nokia · 2024-12-01T03:47:39Z

@mlok-nokia, can you divide this PR in two, one for the config_db related change and one for the platform related change
Platform related change is moved to PR - #20979. Please review it

arlakshm · 2024-12-02T05:19:36Z

/Azp run Azure.sonic-buildimage

azure-pipelines · 2024-12-02T05:19:48Z

Azure Pipelines successfully started running 1 pipeline(s).

src/sonic-yang-models/yang-models/sonic-asic-sensors.yang

mssonicbld · 2025-01-08T05:40:08Z

Cherry-pick PR to msft-202405: Azure/sonic-buildimage-msft#500

mlok-nokia · 2025-01-17T15:58:16Z

@arlakshm This PR needs to be merged to 202405 branch. Please cherry-pick it to the branch 202405. Thanks

rlhui · 2025-01-17T16:18:56Z

@arlakshm This PR needs to be merged to 202405 branch. Please cherry-pick it to the branch 202405. Thanks

@mlok-nokia what's the reason?

…on the platform.json (sonic-net#20826) For any platform which supports the asic_sensors pulling, it requires the configuration files (config_db#.json) contain the following configuration to trigger the system to poll the ASIC sensors temperature. Fixes Nokia-ION/ndk#48 Adding Yang model support to fixes sonic-net#20633 --------- Signed-off-by: mlok <[email protected]>

mlok-nokia · 2025-01-21T22:10:33Z

@arlakshm This PR needs to be merged to 202405 branch. Please cherry-pick it to the branch 202405. Thanks

@mlok-nokia what's the reason?

The following Nokia pizza boxes support the asic_sensors. I was told that they require this PR also.
x86_64-nokia_ixr7220_h4_32d-r0
arm64-nokia_ixs7215_52xb-r0
x86_64-nokia_ixr7220_h4-r0
x86_64-nokia_ixr7220_h5_64d-r0

rlhui · 2025-01-21T22:21:04Z

could it go to 202411 only? Adding @bingwang-ms to assess this for 202405 cherry-pick request

mlok-nokia · 2025-01-30T22:38:29Z

could it go to 202411 only? Adding @bingwang-ms to assess this for 202405 cherry-pick request

It could go into branch 202411. Also this PR on 202411 requires the YangModel PR #21579

…on the platform.json (#20826) (#1023) Why I did it For any platform which supports the asic_sensors pulling, it requires the configuration files (config_db#.json) contain the following configuration to trigger the system to poll the ASIC sensors temperature. Fixes Nokia-ION/ndk#48 Adding Yang model support to fixes #20633 Work item tracking Microsoft ADO 32401949: Port sonic-net/sonic-buildimage#20826 to 202503 branch

With the enhancement introduced in PR sonic-net#20826 - "[asic_sensors] Generate the ASIC sensor polling configuration based on the platform.json" - we can now define ASIC sensor polling settings directly in platform.json. This change removes the need for a custom.json override and simplifies platform-specific configuration by centralizing the polling interval and status settings under platform.json. Signed-off-by: Michael Zaidman <[email protected]>

…on the platform.json (sonic-net#20826) For any platform which supports the asic_sensors pulling, it requires the configuration files (config_db#.json) contain the following configuration to trigger the system to poll the ASIC sensors temperature. Fixes Nokia-ION/ndk#48 Adding Yang model support to fixes sonic-net#20633 --------- Signed-off-by: mlok <[email protected]>

mlok-nokia marked this pull request as ready for review November 15, 2024 22:44

mlok-nokia force-pushed the asic_sensor_pulling_config branch 2 times, most recently from fba67c0 to b26025d Compare November 18, 2024 19:05

judyjoseph added the Request for 202405 Branch label Nov 18, 2024

mlok-nokia changed the title ~~[asic_sensors] Generate the aisc_sensors pulling configuration based on the platform.json~~ [asic_sensors] Generate the asic_sensors polling configuration based on the platform.json Nov 18, 2024

rlhui requested a review from judyjoseph November 20, 2024 18:15

mlok-nokia requested a review from qiluo-msft as a code owner November 21, 2024 15:34

mlok-nokia changed the title ~~[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json~~ [asic_sensors] Generate the asic_sensors polling configuration based on the platform.json and Yang Model supports Nov 21, 2024

mssonicbld added the Cherry Pick Conflict_202405 label Nov 21, 2024

mlok-nokia force-pushed the asic_sensor_pulling_config branch 2 times, most recently from 7c56970 to f991ffc Compare November 21, 2024 22:10

judyjoseph reviewed Nov 22, 2024

View reviewed changes

src/sonic-yang-models/yang-models/sonic-asic-sensors.yang Outdated Show resolved Hide resolved

rlhui assigned mlok-nokia and mssonicbld Nov 27, 2024

arlakshm requested a review from liamkearney-msft November 27, 2024 22:53

mlok-nokia mentioned this pull request Dec 1, 2024

[Nokia][asic-sensors] Modify the platform.json to enable the asic_sensors polling on Nokia platforms #20979

Merged

11 tasks

liamkearney-msft approved these changes Dec 2, 2024

View reviewed changes

arlakshm reviewed Dec 2, 2024

View reviewed changes

src/sonic-yang-models/yang-models/sonic-asic-sensors.yang Outdated Show resolved Hide resolved

judyjoseph previously approved these changes Dec 2, 2024

View reviewed changes

rlhui added Request for 202411 Branch Chassis 🤖 Modular chassis support labels Dec 24, 2024

rlhui merged commit 18efba1 into sonic-net:master Dec 24, 2024

judyjoseph mentioned this pull request Dec 24, 2024

[YangModel][asic_sensors] Add ASIC_SENSORS yang models #21218

Merged

12 tasks

rlhui added the Request for msft-202405 Branch label Jan 3, 2025

arlakshm removed the Request for 202405 Branch label Jan 8, 2025

Javier-Tan mentioned this pull request Jan 8, 2025

[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json (#20826) Azure/sonic-buildimage-msft#499

Closed

Javier-Tan added Approved for msft-202405 Branch and removed Request for msft-202405 Branch labels Jan 8, 2025

mssonicbld mentioned this pull request Jan 8, 2025

[action] [PR:20826] [asic_sensors] Generate the asic_sensors polling configuration based on the platform.json Azure/sonic-buildimage-msft#500

Merged

12 tasks

mssonicbld added the Created PR to msft-202405 Branch label Jan 8, 2025

tjchadaga added the Request for msft-202503 Branch label Apr 10, 2025

arlakshm mentioned this pull request Apr 18, 2025

[asic_sensors] Generate the asic_sensors polling configuration based on the platform.json (#20826) Azure/sonic-buildimage-msft#1023

Merged

10 tasks

CharlieChenEC mentioned this pull request Jun 24, 2025

Introduce Xsight X2-Based Device for SONiC using Accton platform #22622

Open

9 tasks

mlok-nokia deleted the asic_sensor_pulling_config branch March 25, 2026 20:10

Conversation

mlok-nokia commented Nov 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Uh oh!

mlok-nokia commented Nov 18, 2024

Uh oh!

mlok-nokia commented Nov 22, 2024

Uh oh!

Uh oh!

judyjoseph commented Nov 22, 2024

Uh oh!

judyjoseph commented Nov 25, 2024

Uh oh!

azure-pipelines bot commented Nov 25, 2024

Uh oh!

arlakshm commented Nov 27, 2024

Uh oh!

azure-pipelines bot commented Nov 27, 2024

Uh oh!

arlakshm commented Nov 27, 2024

Uh oh!

mlok-nokia commented Dec 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arlakshm commented Dec 2, 2024

Uh oh!

azure-pipelines bot commented Dec 2, 2024

Uh oh!

Uh oh!

mssonicbld commented Jan 8, 2025

Uh oh!

mlok-nokia commented Jan 17, 2025

Uh oh!

rlhui commented Jan 17, 2025

Uh oh!

mlok-nokia commented Jan 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rlhui commented Jan 21, 2025

Uh oh!

mlok-nokia commented Jan 30, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

mlok-nokia commented Nov 15, 2024 •

edited

Loading

mlok-nokia commented Dec 1, 2024 •

edited

Loading

mlok-nokia commented Jan 21, 2025 •

edited

Loading