To Fix the issue: redis-cli build broken on Debian/Bookworm (librdb use-after-free)#20759
Merged
rlhui merged 1 commit intosonic-net:masterfrom Nov 12, 2024
Merged
To Fix the issue: redis-cli build broken on Debian/Bookworm (librdb use-after-free)#20759rlhui merged 1 commit intosonic-net:masterfrom
rlhui merged 1 commit intosonic-net:masterfrom
Conversation
saiarcot895
approved these changes
Nov 11, 2024
9 tasks
Contributor
Author
|
@rlhui , please cherry-pick this to 202405. Thanks. |
qiluo-msft
previously approved these changes
Nov 11, 2024
Contributor
|
It doesn't look like |
saiarcot895
approved these changes
Nov 11, 2024
Contributor
Author
Addressed. |
Contributor
|
LGTM (1:1 my original fix + 1 version update, so should be good 😛) |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Nov 13, 2024
…ree) (sonic-net#20759) Fix sonic-net#20757 Why I did it To Fix the issue: redis-cli build broken on Debian/Bookworm (librdb use-after-free) sonic-net#20757 How I did it This issue is a known open issue below: redis/librdb#55 According to Walter Doekes's solution, currently to work around it by adding -floto=auto compiler option. make -j$(SONIC_CONFIG_MAKE_JOBS) WARNS='-Wall -Wextra -pedantic -flto=auto'
Collaborator
|
Cherry-pick PR to 202405: #20779 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 13, 2024
…ree) (#20759) Fix #20757 Why I did it To Fix the issue: redis-cli build broken on Debian/Bookworm (librdb use-after-free) #20757 How I did it This issue is a known open issue below: redis/librdb#55 According to Walter Doekes's solution, currently to work around it by adding -floto=auto compiler option. make -j$(SONIC_CONFIG_MAKE_JOBS) WARNS='-Wall -Wextra -pedantic -flto=auto'
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
To Fix the issue: redis-cli build broken on Debian/Bookworm (librdb use-after-free)
#20757
How I did it
This issue is a known open issue below:
redis/librdb#55
According to Walter Doekes's solution, currently to work around it by adding -floto=auto compiler option.
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog