[sonic-cfggen] Add support to generate sample t1 config#2039
Merged
lguohan merged 6 commits intosonic-net:masterfrom Sep 16, 2018
Merged
[sonic-cfggen] Add support to generate sample t1 config#2039lguohan merged 6 commits intosonic-net:masterfrom
lguohan merged 6 commits intosonic-net:masterfrom
Conversation
lguohan
reviewed
Sep 13, 2018
Contributor
|
will there be any test cases to check the output? |
lguohan
requested changes
Sep 14, 2018
Collaborator
lguohan
left a comment
There was a problem hiding this comment.
can you add choices for preset option?
Contributor
Author
|
Added. Now user will be able to see a list of preset templates in the |
lguohan
approved these changes
Sep 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Add support in
sonic-cfggento generate a sample LeafRouter configuration json file for any SKU. This is a preparation to remove sample minigraphs from platform folders and to use auto-generated sample config json files instead.- How to verify it
sonic-cfggen -H -k Mellanox-SN2700 --preset t1will print a sample config_db.json file which is similar to the one generated from current default minigraph.