[Platforms] Add stubs for new API in SfpUtilBase to platforms which haven't added#2038
Merged
lguohan merged 1 commit intosonic-net:masterfrom Sep 12, 2018
keboliu:xcvrd_stubs
Merged
[Platforms] Add stubs for new API in SfpUtilBase to platforms which haven't added#2038lguohan merged 1 commit intosonic-net:masterfrom keboliu:xcvrd_stubs
lguohan merged 1 commit intosonic-net:masterfrom
keboliu:xcvrd_stubs
Conversation
lguohan
approved these changes
Sep 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
to fix issue #2017
New API get_transceiver_change_event() introduced to SfpUtilBase, need add stubs to the sfputil plugin of the platforms which haven't implement this methond yet.
- How I did it
add a definiton of get_transceiver_change_event() to the sfputil plugin, in the function it will raise NotImplementedError.
- How to verify it
need each platform to run command to check sfp presence.
- Description for the changelog
Changes to be committed:
(use "git reset HEAD ..." to unstage)
- A picture of a cute animal (not mandatory but encouraged)