[minigraph]: Add PORTCHANNEL_MEMBER configurations#2034
Merged
lguohan merged 1 commit intosonic-net:masterfrom Sep 12, 2018
Merged
[minigraph]: Add PORTCHANNEL_MEMBER configurations#2034lguohan merged 1 commit intosonic-net:masterfrom
lguohan merged 1 commit intosonic-net:masterfrom
Conversation
Signed-off-by: Shu0T1an ChenG <[email protected]>
Contributor
Author
|
mellanox build failure is due to unrelated network reasons |
lguohan
approved these changes
Sep 12, 2018
5 tasks
liat-grozovik
pushed a commit
that referenced
this pull request
Feb 1, 2022
53c630b [CoPP] Add always_enabled field to coppmgr logic ([minigraph]: Add PORTCHANNEL_MEMBER configurations #2034) adcf69d [cbf] Fix cbf sync error ([aboot] add SWI_DEFAULT support in boot0 #2056) 69f9ee5 fix mclagsyncd out of order initialization ([submodules] update dbsyncd and snmpagent pointers for LLDP MIB support #2112)
theasianpianist
added a commit
to theasianpianist/sonic-buildimage
that referenced
this pull request
Mar 21, 2022
Include following commits:
- d061e27 [tunnelmgrd]: Warm boot support (sonic-net#2166)
- 73ced6e Remove port serdes object before removing port (sonic-net#2152)
- 6ac0b9b [CoPP] Add always_enabled field to coppmgr logic (sonic-net#2034) (sonic-net#2147)
Signed-off-by: Lawrence Lee <[email protected]>
6 tasks
theasianpianist
added a commit
that referenced
this pull request
Mar 22, 2022
Include following commits:
- d061e27 [tunnelmgrd]: Warm boot support (#2166)
- 73ced6e Remove port serdes object before removing port (#2152)
- 6ac0b9b [CoPP] Add always_enabled field to coppmgr logic (#2034) (#2147)
Signed-off-by: Lawrence Lee <[email protected]>
Ndancejic
pushed a commit
to Ndancejic/sonic-buildimage
that referenced
this pull request
May 3, 2022
- What I did Add the new design for copp manager - always_enabled field in copp_cfg.json file. - Why I did it A change was done for traps needs to be installed but doesn't have feature (arp, udld, lacp, ip2me), in the new implementation, coppmgr will not automatically install traps which has no entry in features table, but will check first if the trap has "always_enabled":"true" field. - How I verified it run tests for making sure traps are installed and not when expecting them to. - Details if related Related to sonic-buildimage change - sonic-net#9302 SONiC mgmt test plan can be found in sonic-net/SONiC#903.
vadymhlushko-mlnx
pushed a commit
to vadymhlushko-mlnx/sonic-buildimage
that referenced
this pull request
Nov 11, 2022
#### What I did Fixes sonic-net#2034 Which lists where handled before in ConfigDb to YANG conversion? - Dictionary of key to Object e.g. ``` "TACPLUS_SERVER": { "1.1.1.1": { <= Key: Object (i.e. {...}) "priority": "1", "tcp_port": "49" }, "1.1.1.2": { "priority": "1", "tcp_port": "49" }, "1.1.1.3": { "priority": "1", "tcp_port": "49" } } ``` - List of values ``` "VLAN": { "Vlan1000": { "vlanid": "1000", "dhcp_servers": [ <= Values "192.0.0.1", "192.0.0.2", "192.0.0.3", "192.0.0.4" ] } } ``` - But there is no handling of Dictionary of Key to Value ``` "DOT1P_TO_TC_MAP": { "Dot1p_to_tc_map1": { <= Key: Value "1": "1", "2": "2", "3": "1", "4": "2" } }, ``` Refer to sonic-net#7375 for more info about how Type 1 list ConfigDb is getting converted to SonicYang. After checking how type1 is handled during ConfigDb to SonicYang conversion. Check the unit-tests here for converting ConfigDb Path to SonicYang xpath. Also added CABLE_LENGTH to ADD_RACK and REMOVE_RACK tests. #### How I did it When handling a list, check if it is of type1. If that's the case call type1 list handling. #### How to verify it unit-test #### Previous command output (if the output of a command-line utility has changed) #### New command output (if the output of a command-line utility has changed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shu0T1an ChenG [email protected]