[chassis][multiasic][sonic-db-cli] No need to access chassis_app_db from namespace in swss.sh

[mlok-nokia]

Why I did it

Currently, in the multiaisc linecard, the sonic-db-cli is not able access from CHASSIS_APP_DB from namespace. The swss,sh call SONIC_DB_CLI to ping and access the CHASSIS_APP_DB. There is also a PR (sonic-net/sonic-swss-common#896) try to address it. Since sonic-db-cli can access the CHASSIS_APP_DB from host instead of the namespace, we modify the swss.sh to use sonic-db-cli instead of SONIC_DB_CLI which use the sonic-db-cli -n asic#.

Work item tracking

• Microsoft ADO (number only):

How I did it

Modify the swss.sh to use sonic_db_cli instead of "SONIC_DB_CLI" to access the CHASSIS_APP_DB since there is no need to access the CHASSIS_APP_DB from namespace in the swss.sh. Comparing to PR sonic-net/sonic-swss-common#896, this PR is more straight forward to address the issue based on the swss.sh implementation. Anyway, both PRs have no conflict.

How to verify it

The mutilasic swss# container should be able to be UP and running without any issue.

Which release branch to backport (provide reason below if selected)

• 201811
• 201911
• 202006
• 202012
• 202106
• 202111
• 202205
• 202211
• 202305
• 202405

Tested branch (Please provide the tested image version)

[x] 202405
[x] master

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

[mlok-nokia]

@arlakshm @judyjoseph This PR address the sonic-db-cli unable to access to the CHASSIS_APP_DB issue from namespace in swss.sh. Please review it. Thanks

[arlakshm]

@arista-nwolfe, @kenneth-arista can you please review as well

[kenneth-arista]

lgtm

[arista-nwolfe]

LGTM

[lguohan]

this is very difficult to understand the diffence between sonic-db-cli and $SONIC_DB_CLI, making code very difficult to maintain, like landmine.

[SuvarnaMeenakshi]

could add a different variable to use sonic-db-cli from host:

if [ "$DEV" ]; then
    NET_NS="$NAMESPACE_PREFIX$DEV" #name of the network namespace
    SONIC_DB_CLI="sonic-db-cli -n $NET_NS"
    SONIC_DB_CLI_HOST="sonic-db-cli"
else
    NET_NS=""
    SONIC_DB_CLI="sonic-db-cli"
    SONIC_DB_CLI_HOST="sonic-db-cli"
fi

[qiluo-msft]

@wenyiz2021 is discuss with @mlok-nokia whether we should close this PR.

[wenyiz2021]

good to close this as sonic-net/sonic-swss-common#883 merged