Skip to content

Updated MMU settings for ingress lossy profile Nokia and Arista chassis#19653

Merged
rlhui merged 1 commit intosonic-net:masterfrom
vmittal-msft:vmittal/nokia-mmu
Aug 3, 2024
Merged

Updated MMU settings for ingress lossy profile Nokia and Arista chassis#19653
rlhui merged 1 commit intosonic-net:masterfrom
vmittal-msft:vmittal/nokia-mmu

Conversation

@vmittal-msft
Copy link
Copy Markdown
Contributor

@vmittal-msft vmittal-msft commented Jul 23, 2024 •
edited
Loading

Why I did it

To fix PFC generation issue during congestion on lossy queues.

Work item tracking
  • Microsoft ADO (28865646):

How I did it

Updated lossy PG threshold to be higher than Queue threshold not to allow PFC generation.

How to verify it

Verified on sonic chassis with configuration check as well as traffic test.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@gechiang gechiang added the Chassis for 202205 branch PRs needed for 202205 branch in msft repo label Jul 23, 2024
@gechiang
Copy link
Copy Markdown
Collaborator

gechiang commented Jul 23, 2024

@vmittal-msft ,
Please provide the MSFT ADO for this PR.

@gechiang gechiang requested a review from lguohan July 23, 2024 17:39
@vmittal-msft
Copy link
Copy Markdown
Contributor Author

vmittal-msft commented Jul 23, 2024

@kenneth-arista @saksarav-nokia for review.

@kenneth-arista
Copy link
Copy Markdown
Collaborator

kenneth-arista commented Jul 24, 2024

Looks okay to me.

@ansrajpu-git ansrajpu-git mentioned this pull request Jul 26, 2024
Merged
8 tasks
@gechiang
Copy link
Copy Markdown
Collaborator

gechiang commented Jul 27, 2024

@vmittal-msft Please submit MSFT ADO for this PR.
Thanks!

This was referenced Jul 31, 2024
Closed
Closed
@judyjoseph
Copy link
Copy Markdown
Contributor

judyjoseph commented Jul 31, 2024

Can we add a test gap to check lossy traffic not generating PFC ? @vmittal-msft

@vmittal-msft
Copy link
Copy Markdown
Contributor Author

vmittal-msft commented Aug 1, 2024

@saksarav-nokia @kenneth-arista please help review/approve.

@vmittal-msft
Copy link
Copy Markdown
Contributor Author

vmittal-msft commented Aug 1, 2024

Can we add a test gap to check lossy traffic not generating PFC ? @vmittal-msft

sonic-net/sonic-mgmt#14123

@vmittal-msft
Copy link
Copy Markdown
Contributor Author

vmittal-msft commented Aug 2, 2024

@rlhui Can you please help merge as @kenneth-arista already approved in comments ?

@rlhui rlhui merged commit 4563c32 into sonic-net:master Aug 3, 2024
@gechiang
Copy link
Copy Markdown
Collaborator

gechiang commented Aug 4, 2024

PR for 202205 MSFT repo: Azure/sonic-buildimage-msft#432

@gechiang gechiang added the Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch label Aug 4, 2024
@gechiang
Copy link
Copy Markdown
Collaborator

gechiang commented Aug 4, 2024

@vmittal-msft , there is a merge conflict for 202405 branch. Please raise a PR in 202405 directly.

@ansrajpu-git ansrajpu-git mentioned this pull request Aug 30, 2024
Closed
@bingwang-ms
Copy link
Copy Markdown
Contributor

bingwang-ms commented Sep 6, 2024

@vmittal-msft Please raise a PR to 202405 branch to address conflict.

1 similar comment
@arlakshm
Copy link
Copy Markdown
Contributor

arlakshm commented Oct 11, 2024

@vmittal-msft Please raise a PR to 202405 branch to address conflict.

@vmittal-msft vmittal-msft mentioned this pull request Oct 30, 2024
Merged
11 tasks
@vmittal-msft
Copy link
Copy Markdown
Contributor Author

vmittal-msft commented Oct 30, 2024

202405 PR - #20651

@vmittal-msft vmittal-msft deleted the vmittal/nokia-mmu branch October 30, 2024 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rlhui rlhui rlhui approved these changes

@gechiang gechiang gechiang approved these changes

@lguohan lguohan Awaiting requested review from lguohan

@kenneth-arista kenneth-arista Awaiting requested review from kenneth-arista

Assignees

@vmittal-msft vmittal-msft

Labels

Chassis for 202205 branch PRs needed for 202205 branch in msft repo Chassis 🤖 Modular chassis support Included in Chassis for 202205 Branch Indicate PR is already in MSFT repo 202205 branch Included in 202405 Branch

Projects

SONiC Chassis
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@vmittal-msft @gechiang @kenneth-arista @judyjoseph @bingwang-ms @arlakshm @rlhui @mssonicbld