Skip to content

add config_db entries for TELEMETRY|gnmi|save_on_set #19309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
baxia-lan merged 2 commits into from
Jul 25, 2024
Merged

add config_db entries for TELEMETRY|gnmi|save_on_set #19309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7dea3e7
add config_db entries for TELEMETRY|gnmi|save_on_set
rlucus Jun 14, 2024
8bea182
add save_on_set to sonic-gnmi.yang
rlucus Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/sonic-yang-models/doc/Configuration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2332,7 +2332,8 @@ and is listed in this table.
"gnmi": {
"client_auth": "true",
"log_level": "2",
"port": "50051"
"port": "50051",
"save_on_set": "false"
}
}
}
Expand Down
4 changes: 4 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests/gnmi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"desc": "TABLE_WITH_INCORRECT_PORT failure.",
"eStrKey": "InvalidValue"
},
"GNMI_TABLE_WITH_INCORRECT_SAVE_ON_SET": {
"desc": "TABLE_WITH_INCORRECT_SAVE_ON_SET failure",
"eStrKey": "InvalidValue"
},
"GNMI_TABLE_WITH_VALID_CONFIG": {
"desc": "TABLE WITH VALID CONFIG."
}
Expand Down
4 changes: 4 additions & 0 deletions src/sonic-yang-models/tests/yang_model_tests/tests/telemetry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,10 @@
"desc": "TABLE_WITH_INCORRECT_PORT failure.",
"eStrKey": "InvalidValue"
},
"TELEMETRY_TABLE_WITH_INCORRECT_SAVE_ON_SET": {
"desc": "TABLE_WITH_INCORRECT_SAVE_ON_SET failure",
"eStrKey": "InvalidValue"
},
"TELEMETRY_TABLE_WITH_VALID_CONFIG": {
"desc": "TABLE WITH VALID CONFIG."
}
Expand Down
20 changes: 19 additions & 1 deletion src/sonic-yang-models/tests/yang_model_tests/tests_config/gnmi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,23 @@
}
}
},
"GNMI_TABLE_WITH_INCORRECT_SAVE_ON_SET": {
"sonic-gnmi:sonic-gnmi": {
"sonic-gnmi:GNMI": {
"certs": {
"ca_crt": "/etc/sonic/credentials/dsmsroot.cer",
"server_crt": "/etc/sonic/credentials/server.cer",
"server_key": "/etc/sonic/credentials/server.key"
},
"gnmi": {
"client_auth": "true",
"log_level": "2",
"port": "50051",
"save_on_set": "wrong"
}
}
}
},
"GNMI_TABLE_WITH_VALID_CONFIG": {
"sonic-gnmi:sonic-gnmi": {
"sonic-gnmi:GNMI": {
Expand All @@ -58,7 +75,8 @@
"gnmi": {
"client_auth": "true",
"log_level": "2",
"port": "50052"
"port": "50052",
"save_on_set": "false"
}
}
}
Expand Down
20 changes: 19 additions & 1 deletion src/sonic-yang-models/tests/yang_model_tests/tests_config/telemetry.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,23 @@
}
}
},
"TELEMETRY_TABLE_WITH_INCORRECT_SAVE_ON_SET": {
"sonic-telemetry:sonic-telemetry": {
"sonic-telemetry:TELEMETRY": {
"certs": {
"ca_crt": "/etc/sonic/telemetry/dsmsroot.cer",
"server_crt": "/etc/sonic/telemetry/streamingtelemetryserver.cer",
"server_key": "/etc/sonic/telemetry/streamingtelemetryserver.key"
},
"gnmi": {
"client_auth": "true",
"log_level": "2",
"port": "50051",
"save_on_set": "wrong"
}
}
}
},
"TELEMETRY_TABLE_WITH_VALID_CONFIG": {
"sonic-telemetry:sonic-telemetry": {
"sonic-telemetry:TELEMETRY": {
Expand All @@ -58,7 +75,8 @@
"gnmi": {
"client_auth": "true",
"log_level": "2",
"port": "50051"
"port": "50051",
"save_on_set": "false"
}
}
}
Expand Down
5 changes: 5 additions & 0 deletions src/sonic-yang-models/yang-models/sonic-gnmi.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ module sonic-gnmi {
description "Port gnmi runs on.";
}

leaf save_on_set {
type boolean;
description "Flag for enabling save on set.";
}

}

}
Expand Down
5 changes: 5 additions & 0 deletions src/sonic-yang-models/yang-models/sonic-telemetry.yang
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,11 @@ module sonic-telemetry {
description "Port gnmi runs on.";
}

leaf save_on_set {
type boolean;
description "Flag for enabling save on set.";
}

}

}
Expand Down