Skip to content

[minigraph] Added support to parse "AssociatedSliceStr" attribute of minigraph#19160

Merged
lguohan merged 26 commits intosonic-net:masterfrom
abdosi:master
Jun 6, 2024
Merged

[minigraph] Added support to parse "AssociatedSliceStr" attribute of minigraph#19160
lguohan merged 26 commits intosonic-net:masterfrom
abdosi:master

Conversation

@abdosi
Copy link
Contributor

@abdosi abdosi commented May 31, 2024

What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type.
Yang model are done as part of : #19094

Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.

Why I did:
In BGP Templates we need to take different action based on this attribute.

How I verify:
UT updated.

abdosi and others added 20 commits August 3, 2023 04:47
Signed-off-by: Abhishek Dosi <[email protected]>
higher value so that BGP learnt default route is higher priority.

Signed-off-by: Abhishek Dosi <[email protected]>
save as `slice_type` as part of DEVICE_METADATA

Signed-off-by: Abhishek Dosi <[email protected]>
@abdosi
Copy link
Contributor Author

abdosi commented May 31, 2024

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi abdosi requested a review from arlakshm May 31, 2024 16:47
@abdosi
Copy link
Contributor Author

abdosi commented May 31, 2024

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Jun 3, 2024

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Jun 3, 2024

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Jun 4, 2024

/azpw ms_conflict

@lguohan
Copy link
Collaborator

lguohan commented Jun 4, 2024

@qiluo-msft , here is another minigraph parse change. can you check if you can accomodate this one?

@abdosi
Copy link
Contributor Author

abdosi commented Jun 4, 2024

/azpw ms_conflict

@abdosi
Copy link
Contributor Author

abdosi commented Jun 4, 2024

/azp run Azure.sonic-buildimage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@abdosi
Copy link
Contributor Author

abdosi commented Jun 5, 2024

@lguohan / @qiluo-msft : please help merge of this.

@lguohan lguohan merged commit bd77337 into sonic-net:master Jun 6, 2024
@abdosi
Copy link
Contributor Author

abdosi commented Jun 11, 2024

@bingwang-ms : can you please pick for 202405.Needed for chassis

mssonicbld pushed a commit to mssonicbld/sonic-buildimage that referenced this pull request Jun 12, 2024
…minigraph (sonic-net#19160)

What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type.
Yang model are done as part of : sonic-net#19094

Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.

Why I did:
In BGP Templates we need to take different action based on this attribute.

Signed-off-by: Abhishek Dosi <[email protected]>
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202405: #19285

mssonicbld pushed a commit that referenced this pull request Jun 15, 2024
…minigraph (#19160)

What I did:
Added support to parse "AssociatedSliceStr" attribute of minigraph and save as slice_type as part of DEVICE_METADATA for Chassis Device Type.
Yang model are done as part of : #19094

Also as part of this change fixed issue of current device not selected correctly as asic_hostname not being correct.

Why I did:
In BGP Templates we need to take different action based on this attribute.

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status
Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants