[dhcp_relay] Revert cli for dhcp per-interface counter#19154
Merged
yxieca merged 4 commits intosonic-net:masterfrom Jun 5, 2024
Merged
[dhcp_relay] Revert cli for dhcp per-interface counter#19154yxieca merged 4 commits intosonic-net:masterfrom
yxieca merged 4 commits intosonic-net:masterfrom
Conversation
…fset issue (sonic-net#16507)" This reverts commit 9c1c82e.
…c-net#16377)" This reverts commit a522a63.
Contributor
Author
|
/azpw run Azure.sonic-buildimage |
Collaborator
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azpw ms_conflict |
1 similar comment
Contributor
Author
|
/azpw ms_conflict |
Contributor
Author
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Jun 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)" This reverts commit 9c1c82e. * Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)" This reverts commit a522a63. * Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
Collaborator
|
Cherry-pick PR to 202311: #19211 |
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Contributor
|
Backport present in 202311 but not in 202405 |
Contributor
Author
|
Hi @bingwang-ms could you please help to approve this backport request? |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Sep 5, 2024
* Revert "add show dhcp_relay ipv4 counter entry, fix interface name offset issue (sonic-net#16507)" This reverts commit 9c1c82e. * Revert "[dhcp-relay]: dhcp/dhcpv6 per interface counter support (sonic-net#16377)" This reverts commit a522a63. * Remove test_show_dhcp_relay_ipv4_counter_with_enabled_dhcp_server
Collaborator
|
Cherry-pick PR to 202405: #20150 |
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Functionality for dhcp per-interface counter has been reverted:
dhcpmon: #18273
dhcprelay: #18288
Cli support hasn't been reverted, but it would not take effect because functionality has been removed.
Work item tracking
How I did it
Revert related code
How to verify it
UT passed
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)